From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: <kvalo@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/4] ath6kl: Fix random reconnect failures
Date: Tue, 13 Sep 2011 15:14:49 +0530 [thread overview]
Message-ID: <20110913094448.GA8296@vasanth-laptop> (raw)
In-Reply-To: <1315648597-17999-4-git-send-email-vthiagar@qca.qualcomm.com>
On Sat, Sep 10, 2011 at 03:26:37PM +0530, Vasanthakumar Thiagarajan wrote:
> Sometimes connect events are received after disconnect
> events from target, this puts host and target in different
> states. When receiving a connect event in a wrong state,
> make sure to send disconnect event to target to maintain
> state consistency.
>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index 0ad458b..2e4bea3 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -460,6 +460,14 @@ void ath6kl_cfg80211_connect_event(struct ath6kl *ar, u16 channel,
> "%s: ath6k not in station mode\n", __func__);
> return;
> }
> +
> + if ((ar->sme_state != SME_CONNECTING) &&
> + (ar->sme_state != SME_CONNECTED)) {
> + ath6kl_dbg(ATH6KL_DBG_WLAN_CFG,
> + "Connect event at inappropriate state, sending disconnect cmd\n");
> + ath6kl_wmi_disconnect_cmd(ar->wmi);
> + return;
> + }
Please hold on this patch, it seems to introduce regression when
testing with different APs.
Vasanth
next prev parent reply other threads:[~2011-09-13 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 9:56 [PATCH 1/4] ath6kl: Remove auth type fall back in auto authentication mode Vasanthakumar Thiagarajan
2011-09-10 9:56 ` [PATCH 2/4] ath6kl: Set the sme_state to disconnected in disconnect() callback Vasanthakumar Thiagarajan
2011-09-10 9:56 ` [PATCH 3/4] ath6kl: Don't give disconnect command in disconnect event handler Vasanthakumar Thiagarajan
2011-09-10 9:56 ` [PATCH 4/4] ath6kl: Fix random reconnect failures Vasanthakumar Thiagarajan
2011-09-13 9:44 ` Vasanthakumar Thiagarajan [this message]
2011-09-15 13:46 ` [PATCH 1/4] ath6kl: Remove auth type fall back in auto authentication mode Kalle Valo
2011-09-15 14:36 ` Vasanthakumar Thiagarajan
2011-09-19 6:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913094448.GA8296@vasanth-laptop \
--to=vthiagar@qca.qualcomm.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).