linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: don't allow zero mac bssid to be configured
Date: Fri, 16 Sep 2011 05:14:16 +0200	[thread overview]
Message-ID: <201109160514.16603.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1316103698.3992.12.camel@jlt3.sipsolutions.net>

On Thursday, September 15, 2011 18:21:38 Johannes Berg wrote:
> How is this related to configuration? 

These 'sdata->u.ibss' values are initialized by ieee80211_ibss_join() which is 
called when a user invokes "iw dev wlan0 ibss join".


> Shouldn't the configuration check be in cfg80211 instead?

No idea. I just stumbled over this obvious bug when I scrolled down the code. 
Feel free to propose an alternative patch if you have a better solution.

Cheers,
Marek

  reply	other threads:[~2011-09-16  3:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 16:07 [PATCH] mac80211: don't allow zero mac bssid to be configured Marek Lindner
2011-09-15 16:21 ` Johannes Berg
2011-09-16  3:14   ` Marek Lindner [this message]
2011-09-16  6:19     ` Johannes Berg
2011-09-16 11:27       ` Marek Lindner
2011-09-16 11:41         ` Johannes Berg
2011-09-16 11:49           ` Johannes Berg
2011-09-16 12:12             ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109160514.16603.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).