Re: [PATCH] mac80211: don't allow zero mac bssid to be configured

[Marek Lindner <lindner_marek@yahoo.de>]

On Friday, September 16, 2011 08:19:16 Johannes Berg wrote:
> On Fri, 2011-09-16 at 05:14 +0200, Marek Lindner wrote:
> > On Thursday, September 15, 2011 18:21:38 Johannes Berg wrote:
> > > How is this related to configuration?
> > 
> > These 'sdata->u.ibss' values are initialized by ieee80211_ibss_join()
> > which is called when a user invokes "iw dev wlan0 ibss join".
> 
> Right. So that means you shouldn't be rejecting the configuration when
> actually using it. You should be rejecting it when it's actually set.

I'd like to remind you that it was not me who designed the original check (my 
patch does not add anything new). If you are looking for somebody to beautify 
your code you'll have to look somewhere else.


> It should be in cfg80211, so NACK for this patch.

As I said: Feel free to propose an alternative patch. I certainly won't.


> Also, this patch is wrong -- at that point, checking for zero address serves
> a difference purpose I think, it means more something along the lines of
> "did we previously find an IBSS".

Can't agree here. This check was conceived to hinder a fixed-bssid 
configuration of 00:00:00:00:00:00.

Cheers,
Marek