From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext
Date: Mon, 19 Sep 2011 16:29:55 -0400 [thread overview]
Message-ID: <20110919202955.GE2608@tuxdriver.com> (raw)
In-Reply-To: <4E7791F5.5050709@openwrt.org>
On Mon, Sep 19, 2011 at 09:03:17PM +0200, Felix Fietkau wrote:
> On 2011-09-19 8:58 PM, Luis R. Rodriguez wrote:
> >On Mon, Sep 19, 2011 at 11:56 AM, Felix Fietkau<nbd@openwrt.org> wrote:
> >> On 2011-09-19 8:43 PM, Luis R. Rodriguez wrote:
> >>>
> >>> On Mon, Sep 19, 2011 at 11:29 AM, Felix Fietkau<nbd@openwrt.org> wrote:
> >>>>
> >>>> On 2011-09-19 8:18 PM, Luis R. Rodriguez wrote:
> >>>>>
> >>>>> On Mon, Sep 19, 2011 at 10:38 AM, Felix Fietkau<nbd@openwrt.org>
> >>>>> wrote:
> >>>>>>
> >>>>>> Signed-off-by: Felix Fietkau<nbd@openwrt.org>
> >>>>>
> >>>>> Can you document on the patch commit log why you do remove this.
> >>>>
> >>>> Because it's unused
> >>>
> >>> Why is it unused?
> >>
> >> Because the code that used to use it was removed a while ago in other
> >> patches.
> >
> >And what did that do :) ?
> It used to set some pointless flags that were never used for anything.
I think he is prodding you to repost with an updated changelog...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-09-19 20:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 17:38 [PATCH v2 1/4] ath9k_hw: make ath9k_hw_set_interrupts use ah->imask by default Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 2/4] ath9k_hw: clean up tx power handling Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext Felix Fietkau
2011-09-19 17:38 ` [PATCH v2 4/4] ath9k_hw: remove EEP_REG_1 Felix Fietkau
2011-09-19 18:18 ` [PATCH v2 3/4] ath: remove ath_regulatory::current_rd_ext Luis R. Rodriguez
2011-09-19 18:29 ` Felix Fietkau
2011-09-19 18:43 ` Luis R. Rodriguez
2011-09-19 18:56 ` Felix Fietkau
2011-09-19 18:58 ` Luis R. Rodriguez
2011-09-19 19:03 ` Felix Fietkau
2011-09-19 20:29 ` John W. Linville [this message]
2011-09-19 18:30 ` [PATCH v2 2/4] ath9k_hw: clean up tx power handling Felix Fietkau
2011-09-19 20:41 ` Luis R. Rodriguez
2011-09-19 20:50 ` Felix Fietkau
2011-09-19 21:14 ` Luis R. Rodriguez
2011-09-19 21:21 ` Felix Fietkau
2011-09-19 21:45 ` Luis R. Rodriguez
2011-09-19 21:54 ` Luis R. Rodriguez
2011-09-19 22:04 ` Felix Fietkau
2011-09-19 22:12 ` Luis R. Rodriguez
2011-09-19 22:13 ` Luis R. Rodriguez
2011-09-19 22:22 ` Felix Fietkau
2011-09-20 2:45 ` Adrian Chadd
2011-09-19 22:02 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110919202955.GE2608@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).