From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, me@bobcopeland.com, mcgrof@gmail.com,
jirislaby@gmail.com, nbd@openwrt.org
Subject: Re: [RFT][PATCH] ath5k: Add rfkill_disable module parameter
Date: Wed, 28 Sep 2011 18:07:12 -0400 [thread overview]
Message-ID: <20110928180712.1436a185@mj> (raw)
In-Reply-To: <20110919160124.GA3218@makis.lan>
On Mon, 19 Sep 2011 19:01:24 +0300
Nick Kossifidis <mickflemm@gmail.com> wrote:
> Add a module parameter to disable hw rf kill (GPIO interrupt) because
> in some cases when the card doesn't come with the laptop, EEPROM
> configuration doesn't match laptop's configuration and rf kill
> interrupt always fires up and disables hw. I thought of moving this
> to debugfs and make it per-card but this way it's easier for users
> and distros to handle.
>
> Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
Tested-by: Pavel Roskin <proski@.gnu.org>
Tested on 2 cards in Mikrotik RB-14 adapter. One was OK without the
patch. The other was shown as hard-blocked by rfkill and didn't work.
With the rfkill_disable=1, both cards work. Soft rfkill is still
working properly.
Please consider a parameter name that indicates that only hard rfkill is
affected, for instance "no_hw_rfkill".
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2011-09-28 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 16:01 [RFT][PATCH] ath5k: Add rfkill_disable module parameter Nick Kossifidis
2011-09-20 10:06 ` Mohammed Shafi
2011-09-20 11:12 ` Nick Kossifidis
2011-09-20 11:30 ` Adrian Chadd
2011-09-20 13:28 ` Mohammed Shafi
2011-09-28 22:07 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110928180712.1436a185@mj \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).