From: Christian Lamparter <chunkeey@googlemail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ian Jeffray <ian@emobix.co.uk>, linux-wireless@vger.kernel.org
Subject: Re: r8712u driver - on ARM
Date: Sat, 1 Oct 2011 20:54:42 +0200 [thread overview]
Message-ID: <201110012054.42461.chunkeey@googlemail.com> (raw)
In-Reply-To: <4E87609E.5030002@lwfinger.net>
On Saturday 01 October 2011 20:49:02 Larry Finger wrote:
> On 10/01/2011 01:10 PM, Ian Jeffray wrote:
> > On 01/10/2011 19:01, Christian Lamparter wrote:
> >> On Saturday 01 October 2011 19:52:37 Larry Finger wrote:
> >>> On 10/01/2011 11:22 AM, Christian Lamparter wrote:
> >>>> On Saturday 01 October 2011 18:01:08 Larry Finger wrote:
> >>>>> Ian,
> >>>>>
> >>>>> Most of the skb assignments in r8712u are aligned OK and most aligned on
> >>>>> 512-byte boundaries, but there was one that had the minimal offset of 14
> >>>>> bytes.
> >>>>> The attached patch should fix it. Does it help?
> >>>> Interesting, this "patch" goes in a completely different direction.
> >>>> Can you tell me where the driver aligns the frames which will be
> >>>> xmitted by the device [i.e.: which
>
> is passed to the usb subsystem
> >>>> by usb_submit_urb]? Because that's what actually matters.
> >>>
> >>> In this driver, all references are to _usb_submit_urb(), which is defined to be
> >>> usb_submit_urb() in one of the header files. That made it easy to insert a test
> >>> for misalignment of the DMA buffer as follows:
> >
> > <snip>
> >
> >>> +static inline int _usb_submit_urb(struct urb *urb, gfp_t mem_flags)
> >>> +{
> >>> + if (urb->transfer_dma& 3) {
> >
> > <snip>
> >
> >> I think you need to check transfer_buffer and not transfer_dma.
> >
> > I tried checking both transfer_buffer and transfer_dma and all
> > were always word aligned. (At least on Blackfin)
> The same with x86_64.
Sure, x86_64 and powerpc set in system.h
grep NET_IP_ALIGN * -R
microblaze/include/asm/system.h:#define NET_IP_ALIGN 2
powerpc/include/asm/system.h:#define NET_IP_ALIGN 0
x86/include/asm/system.h:#define NET_IP_ALIGN 0
well, it looks like Realtek did a better job then and unfortunately
your problem is related to something else.
Regards,
Chr
next prev parent reply other threads:[~2011-10-01 18:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 15:36 r8712u driver - on ARM Ian Jeffray
2011-09-27 16:24 ` Larry Finger
2011-09-30 18:39 ` Ian Jeffray
2011-09-30 19:06 ` Christian Lamparter
2011-10-01 0:51 ` Larry Finger
2011-10-01 16:01 ` Larry Finger
2011-10-01 16:22 ` Christian Lamparter
2011-10-01 17:52 ` Larry Finger
2011-10-01 18:01 ` Christian Lamparter
2011-10-01 18:10 ` Ian Jeffray
2011-10-01 18:49 ` Larry Finger
2011-10-01 18:54 ` Christian Lamparter [this message]
2011-10-01 19:24 ` Larry Finger
2011-10-01 23:24 ` Ian Jeffray
2011-10-12 15:30 ` Ian Jeffray
2011-10-12 17:28 ` Larry Finger
2011-10-01 17:00 ` Ian Jeffray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110012054.42461.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ian@emobix.co.uk \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).