[patch] fix the definition of AR9170_PHY_REG_CURRENT_RSSI

[patch] fix the definition of AR9170_PHY_REG_CURRENT_RSSI

[Adrian Chadd]

Hi Christian,

Although it currently isn't used anywhere, I thought it'd be
worthwhile fixing the definition of AR9170_PHY_REG_CURRENT_RSSI.
It's at AR_PHY(271) rather than AR_PHY(263).

The carl9170 driver may also suffer the same problem. The older
version I have lying around here doesn't seem to use
AR9170_PHY_REG_CURRENT_RSSI anywhere but it is defined.

Thanks,


Adrian

diff --git a/include/shared/phy.h b/include/shared/phy.h
index 024fb42..08b56eb 100644
--- a/include/shared/phy.h
+++ b/include/shared/phy.h
@@ -387,7 +387,7 @@
 #define        AR9170_PHY_REG_CAL_MEAS_3(_i)           (AR9170_PHY_REG_BASE + \
                                                 0x041c + ((_i) << 12))

-#define        AR9170_PHY_REG_CURRENT_RSSI
(AR9170_PHY_REG_BASE + 0x041c)
+#define        AR9170_PHY_REG_CURRENT_RSSI
(AR9170_PHY_REG_BASE + 0x043c)

 #define        AR9170_PHY_REG_RFBUS_GRANT
(AR9170_PHY_REG_BASE + 0x0420)
 #define                AR9170_PHY_RFBUS_GRANT_EN               0x00000001

Re: [patch] fix the definition of AR9170_PHY_REG_CURRENT_RSSI

[Christian Lamparter]

On Tuesday, October 04, 2011 02:30:51 AM Adrian Chadd wrote:
> Hi Christian,
> 
> Although it currently isn't used anywhere, I thought it'd be
> worthwhile fixing the definition of AR9170_PHY_REG_CURRENT_RSSI.
> It's at AR_PHY(271) rather than AR_PHY(263).
> 
> The carl9170 driver may also suffer the same problem. The older
> version I have lying around here doesn't seem to use
> AR9170_PHY_REG_CURRENT_RSSI anywhere but it is defined.
> 
> Thanks,
	Adrian
I have to thank you :). I've commited your change and I hope
I get around to restore carl9170fw.git tree anytime "soon".

BTW, do you have any technical docs about the phy as well?
Or how do you know about the mix-up?

Regards,
	Christian

Re: [patch] fix the definition of AR9170_PHY_REG_CURRENT_RSSI

[Christian Lamparter]

On Tuesday, October 04, 2011 02:30:51 AM Adrian Chadd wrote:
> Although it currently isn't used anywhere, I thought it'd be
> worthwhile fixing the definition of AR9170_PHY_REG_CURRENT_RSSI.
> It's at AR_PHY(271) rather than AR_PHY(263).
>
> -#define        AR9170_PHY_REG_CURRENT_RSSI
> (AR9170_PHY_REG_BASE + 0x041c)
> +#define        AR9170_PHY_REG_CURRENT_RSSI
> (AR9170_PHY_REG_BASE + 0x043c) 

Hello again,

I had some time to check what is on 0x043c.
With AR9170 it looks like to be "0". This
wouldn't be surprising, however the old reg
0x041c seems to jumps around a lot [as
expected from the current rssi].
Adrian, are you sure the source is accurate?

Felix, do you know something about the
CURRENT_RSSI register?

Regards,
	Chr

Re: [patch] fix the definition of AR9170_PHY_REG_CURRENT_RSSI

[Adrian Chadd]

On 10 October 2011 05:02, Christian Lamparter <chunkeey@googlemail.com> wrote:
> Hello again,
>
> I had some time to check what is on 0x043c.
> With AR9170 it looks like to be "0". This
> wouldn't be surprising, however the old reg
> 0x041c seems to jumps around a lot [as
> expected from the current rssi].
> Adrian, are you sure the source is accurate?

I'll have to double-check! I apologise in advance if it turns out this
isn't the case.

> Felix, do you know something about the
> CURRENT_RSSI register?

Thanks,


Adrian