Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 3/6] ath6kl: return error block size is not power of 2
Date: Wed, 05 Oct 2011 12:23:25 +0300	[thread overview]
Message-ID: <20111005092325.1095.72436.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111005092305.1095.713.stgit@localhost6.localdomain6>

Currently only a warning is emitted but no error is returned.

Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath6kl/htc_hif.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/htc_hif.c b/drivers/net/wireless/ath/ath6kl/htc_hif.c
index 86b1cc7..4a5e9a3 100644
--- a/drivers/net/wireless/ath/ath6kl/htc_hif.c
+++ b/drivers/net/wireless/ath/ath6kl/htc_hif.c
@@ -621,6 +621,7 @@ int ath6kldev_setup(struct ath6kl_device *dev)
 	/* must be a power of 2 */
 	if ((dev->htc_cnxt->block_sz & (dev->htc_cnxt->block_sz - 1)) != 0) {
 		WARN_ON(1);
+		status = -EINVAL;
 		goto fail_setup;
 	}
 


  parent reply	other threads:[~2011-10-05  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  9:23 [PATCH 1/6] ath6kl: remove unused parameters from struct wmi Kalle Valo
2011-10-05  9:23 ` [PATCH 2/6] ath6kl: fix struct host_app_area endian handling Kalle Valo
2011-10-05  9:23 ` Kalle Valo [this message]
2011-10-05  9:23 ` [PATCH 4/6] ath6kl: move htc_hif to hif.c Kalle Valo
2011-10-05  9:23 ` [PATCH 5/6] ath6kl: remove unused values from htc_hif.h Kalle Valo
2011-10-05  9:23 ` [PATCH 6/6] ath6kl: move remaining content from htc_hif.h to hif.h Kalle Valo
2011-10-06  9:01 ` [PATCH 1/6] ath6kl: remove unused parameters from struct wmi Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111005092325.1095.72436.stgit@localhost6.localdomain6 \
    --to=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox