Linux wireless drivers development
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Bing Zhao <bzhao@marvell.com>, g@tuxdriver.com
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Amitkumar Karwar <akarwar@marvell.com>,
	Kiran Divekar <dkiran@marvell.com>,
	Yogesh Powar <yogeshp@marvell.com>,
	Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH] mwifiex: add support for Marvell pcie8766 chipset
Date: Tue, 11 Oct 2011 16:39:36 -0400	[thread overview]
Message-ID: <20111011203936.GL6558@tuxdriver.com> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F704308155977E8@SC-VEXCH1.marvell.com>

On Thu, Oct 06, 2011 at 08:30:53PM -0700, Bing Zhao wrote:
> Hi John,
> 
> > -----Original Message-----
> > From: Bing Zhao [mailto:bzhao@marvell.com]
> > Sent: Monday, October 03, 2011 9:08 PM
> > To: linux-wireless@vger.kernel.org
> > Cc: John W. Linville; Amitkumar Karwar; Kiran Divekar; Yogesh Powar; Frank Huang; Bing Zhao
> > Subject: [PATCH] mwifiex: add support for Marvell pcie8766 chipset
> > 
> > From: Amitkumar Karwar <akarwar@marvell.com>
> > 
> > This patch supports 88W8766P chipset with a PCIe interface.
> > 
> > The corresponding firmware image file is located at:
> > "mrvl/pcie8766_uapsta.bin"
> > 
> > Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> > Signed-off-by: Ramesh Radhakrishnan <rramesh@marvell.com>
> > Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
> > Signed-off-by: Kiran Divekar <dkiran@marvell.com>
> > Signed-off-by: Bing Zhao <bzhao@marvell.com>
> > Signed-off-by: Frank Huang <frankh@marvell.com>
> 
> Could you please apply this patch? It doesn't depend on the other patches we are working on.
> 
> Thanks,
> Bing

It generates warnings...

  LD [M]  drivers/net/wireless/mwifiex/mwifiex_pcie.o
WARNING: drivers/net/wireless/mwifiex/mwifiex_pcie.o(.data+0x18): Section mismatch in reference from the variable mwifiex_pcie to the variable .devinit.rodata:mwifiex_ids
The variable mwifiex_pcie references
the variable __devinitconst mwifiex_ids
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: drivers/net/wireless/mwifiex/mwifiex_pcie.o(.data+0x20): Section mismatch in reference from the variable mwifiex_pcie to the function .devinit.text:mwifiex_pcie_probe()
The variable mwifiex_pcie references
the function __devinit mwifiex_pcie_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-10-11 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04  4:08 [PATCH] mwifiex: use separate wait queue for each command node Bing Zhao
2011-10-04  4:08 ` [PATCH] mwifiex: add support for Marvell pcie8766 chipset Bing Zhao
2011-10-07  3:30   ` Bing Zhao
2011-10-11 20:39     ` John W. Linville [this message]
2011-10-11 21:32       ` Bing Zhao
2011-10-04  6:29 ` [PATCH] mwifiex: use separate wait queue for each command node Johannes Berg
2011-10-04 18:50   ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111011203936.GL6558@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=akarwar@marvell.com \
    --cc=bzhao@marvell.com \
    --cc=dkiran@marvell.com \
    --cc=frankh@marvell.com \
    --cc=g@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yogeshp@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox