linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] ath9k_hw: Fix ASPM L1 issue for AR9462
Date: Wed, 12 Oct 2011 14:50:34 -0400	[thread overview]
Message-ID: <20111012185034.GH18764@tuxdriver.com> (raw)
In-Reply-To: <20111012184043.GG18764@tuxdriver.com>

On Wed, Oct 12, 2011 at 02:40:44PM -0400, John W. Linville wrote:
> On Mon, Oct 10, 2011 at 11:25:45AM +0530, Rajkumar Manoharan wrote:
> > Because of not clearing Bit 14 of AR_WA, the ASPM L1 is not
> > enabled when entering into sleep mode. AR9462 does not need
> > bit 14 to be set.
> > 
> > Cc: stable@kernel.org
> > Signed-off-by: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
> 
>   CC [M]  drivers/net/wireless/ath/ath9k/hw.o
> drivers/net/wireless/ath/ath9k/hw.c: In function ‘__ath9k_hw_init’:
> drivers/net/wireless/ath/ath9k/hw.c:544:2: error: implicit declaration of function ‘AR_SREV_9462’
> 
> Missing a patch dependency?

I see that is defined by a series posted just before that -- one that
hasn't even appeared in wireless-next yet.  Cc: stable@kernel.org
seems a bit inappropriate...

That series needs rework anyway -- how about you just fold this one
into that earlier series?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-10-12 19:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10  5:55 [PATCH] ath9k_hw: Fix ASPM L1 issue for AR9462 Rajkumar Manoharan
2011-10-12 18:40 ` John W. Linville
2011-10-12 18:50   ` John W. Linville [this message]
2011-10-13  3:46     ` Rajkumar Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111012185034.GH18764@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmanohar@qca.qualcomm.com \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).