From: "John W. Linville" <linville@tuxdriver.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the moduleh tree
Date: Wed, 12 Oct 2011 15:26:34 -0400 [thread overview]
Message-ID: <20111012192634.GI18764@tuxdriver.com> (raw)
In-Reply-To: <4E95E9C5.6060006@broadcom.com>
On Wed, Oct 12, 2011 at 09:25:57PM +0200, Arend van Spriel wrote:
> On 10/12/2011 08:29 AM, Stephen Rothwell wrote:
> > Hi Paul,
> >
> > After merging the moduleh tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/net/wireless/brcm80211/brcmutil/utils.c:20:15: error: expected declaration specifiers or '...' before string constant
> > drivers/net/wireless/brcm80211/brcmutil/utils.c:21:20: error: expected declaration specifiers or '...' before string constant
> > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int]
> > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c:51:1: warning: parameter names (without types) in function declaration [enabled by default]
> >
> > Caused by commit 5b435de0d786 ("net: wireless: add brcm80211 drivers")
> > from the wireless tree interacting with the module.h split up.
> >
> > These files clearly should include module.h (John, please apply this to the
> > wireless tree):
> >
> > From d89b14ffc84a2b8a54ffe89453b8bbf9cabf1468 Mon Sep 17 00:00:00 2001
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 12 Oct 2011 17:07:06 +1100
> > Subject: [PATCH] net: wireless: brcm80211: include module.h
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Hi John,
>
> Do you intend to take this patch as well. I used it to prepare the patch
> series I sent earlier titled "[PATCH 00/22] brcm80211: mainline patch
> related cleanup" identified by:
>
> Message-ID: <1318445492-24207-1-git-send-email-arend@broadcom.com>
>
> Gr. AvS
>
> ps: If you want the bare patch file, I still have it on disk here.
Please send it to me -- I missed the original.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-10-12 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111012172954.4d5a638ef2a399b72bce5bf1@canb.auug.org.au>
2011-10-12 19:25 ` linux-next: build failure after merge of the moduleh tree Arend van Spriel
2011-10-12 19:26 ` John W. Linville [this message]
[not found] <20111004180333.44f741dc08063a918c9b581f@canb.auug.org.au>
2011-10-04 7:35 ` Kalle Valo
2011-10-04 8:14 ` Stephen Rothwell
2011-10-04 15:09 ` Larry Finger
[not found] <20110928183552.cb27a2b28b02fec275bca009@canb.auug.org.au>
2011-09-28 16:42 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012192634.GI18764@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).