From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 3/4] ath6kl: don't dump full htc packets
Date: Thu, 13 Oct 2011 15:21:45 +0300 [thread overview]
Message-ID: <20111013122145.30551.50371.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111013122115.30551.94.stgit@localhost6.localdomain6>
It's currently possible to dump full sdio packets, so dumping htc packets
is not strictly needed. So remove it, we can always add it back if
there ever comes a need for that.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/htc.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/htc.c b/drivers/net/wireless/ath/ath6kl/htc.c
index 840f1b3..3cd3ef5 100644
--- a/drivers/net/wireless/ath/ath6kl/htc.c
+++ b/drivers/net/wireless/ath/ath6kl/htc.c
@@ -1431,10 +1431,6 @@ static int ath6kl_htc_rx_process_hdr(struct htc_target *target,
if (n_lkahds != NULL)
*n_lkahds = 0;
- /* FIXME: is this needed? */
- ath6kl_dbg_dump(ATH6KL_DBG_HTC, "htc rx", "htc rx",
- packet->buf, packet->act_len);
-
/*
* NOTE: we cannot assume the alignment of buf, so we use the safe
* macros to retrieve 16 bit fields.
@@ -1516,13 +1512,6 @@ fail_rx:
if (status)
ath6kl_dbg_dump(ATH6KL_DBG_HTC, "htc rx bad packet",
"", packet->buf, packet->act_len);
- else {
- /* FIXME: is this needed? */
- if (packet->act_len > 0)
- ath6kl_dbg_dump(ATH6KL_DBG_HTC,
- "htc rx application message", "",
- packet->buf, packet->act_len);
- }
return status;
}
next prev parent reply other threads:[~2011-10-13 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 12:21 [PATCH 1/4] ath6kl: merge htc debug levels Kalle Valo
2011-10-13 12:21 ` [PATCH 2/4] ath6kl: cleanup htc debug messages Kalle Valo
2011-10-13 12:21 ` Kalle Valo [this message]
2011-10-13 12:21 ` [PATCH 4/4] ath6kl: add debug level for hif Kalle Valo
2011-10-17 16:46 ` [PATCH 1/4] ath6kl: merge htc debug levels Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013122145.30551.50371.stgit@localhost6.localdomain6 \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox