From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 3/5] ath6kl: fix WLAN_ENABLE usage in ath6kl_close()
Date: Sun, 30 Oct 2011 21:16:33 +0200 [thread overview]
Message-ID: <20111030191633.20466.70964.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111030190922.20466.299.stgit@localhost6.localdomain6>
If ath6kl_init_hw_stop() failed with an error WLAN_ENABLED would not
be cleared. Found during code review and just a theoretical issue.
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath6kl/main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c
index 717ed22..def0b7f 100644
--- a/drivers/net/wireless/ath/ath6kl/main.c
+++ b/drivers/net/wireless/ath/ath6kl/main.c
@@ -1147,7 +1147,6 @@ static int ath6kl_close(struct net_device *dev)
0, 0, 0, 0, 0, 0, 0, 0, 0))
return -EIO;
- clear_bit(WLAN_ENABLED, &vif->flags);
}
ath6kl_cfg80211_scan_complete_event(vif, -ECANCELED);
@@ -1157,6 +1156,8 @@ static int ath6kl_close(struct net_device *dev)
if (ret)
return ret;
+ clear_bit(WLAN_ENABLED, &vif->flags);
+
return 0;
}
next prev parent reply other threads:[~2011-10-30 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 19:15 [PATCH 0/5] ath6kl: cut power when interface is down Kalle Valo
2011-10-30 19:15 ` [PATCH 1/5] ath6kl: create ath6kl_hif_stop() Kalle Valo
2011-10-30 19:16 ` [PATCH 2/5] ath6kl: power down hardware when interface is down Kalle Valo
2011-10-30 19:16 ` Kalle Valo [this message]
2011-10-30 19:16 ` [PATCH 4/5] ath6kl: print firmware crashes always Kalle Valo
2011-10-30 19:16 ` [PATCH 5/5] ath6kl: print seqno in htc debug logs Kalle Valo
2011-11-01 6:06 ` [PATCH 0/5] ath6kl: cut power when interface is down Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111030191633.20466.70964.stgit@localhost6.localdomain6 \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).