Re: [RFC v2 2/2] ath9k: integrate initial DFS module

[Christian Lamparter <chunkeey@googlemail.com>]

On Thursday, November 03, 2011 02:55:53 PM Zefir Kurtisi wrote:
> This patch integrates the DFS module into ath9k, including
>  * building the module into ath9k_hw
>  * setting up DFS debugfs
>  * defining HW capability flag for DFS support
>  * setting this flag by DFS supporting devices
>    (so far: AR_SREV_9280_20_OR_LATER, TBC)
>  * setting PHYRADAR rx filter flag to enable radar
>    pulse reporting
>  * forward radar PHY errors to dfs module
> 
> This is WIP and at its current stage is limited to test ath9k
> pulse detection capabilities. The DFS pattern matching is
> TBD in the higher layers and is not part of this patch.
> 
> CONFIG_ATH9K_DFS must be set to enable pulse detection.
where? There's no kconfig option, yet it has the CONFIG_ perifx.
So people will be looking for it.

This is exactly why I made such a big fuss about CONFIG_XYZ issue last time.
<http://www.mail-archive.com/ath9k-devel@lists.ath9k.org/msg06825.html> 
Just drop the ifdef.

> Signed-off-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
> ---
>  drivers/net/wireless/ath/ath9k/Makefile |    2 ++
>  drivers/net/wireless/ath/ath9k/debug.c  |    3 +++
>  drivers/net/wireless/ath/ath9k/debug.h  |    2 ++
>  drivers/net/wireless/ath/ath9k/hw.c     |   12 ++++++++++++
>  drivers/net/wireless/ath/ath9k/hw.h     |    1 +
>  drivers/net/wireless/ath/ath9k/main.c   |   17 +++++++++++++++++
>  drivers/net/wireless/ath/ath9k/recv.c   |   18 +++++++++++++-----
>  7 files changed, 50 insertions(+), 5 deletions(-)
> 
> --- a/drivers/net/wireless/ath/ath9k/hw.c
> +++ b/drivers/net/wireless/ath/ath9k/hw.c
> @@ -2333,6 +2333,18 @@ int ath9k_hw_fill_cap_info(struct ath_hw *ah)
>  		pCap->pcie_lcr_offset = 0x80;
>  	}
>  
> +#ifdef CONFIG_ATH9K_DFS
> +	/*
> +	 * enable radar detection on DFS supporting devices
> +	 */
> +	if (AR_SREV_9280_20_OR_LATER(ah)) {
> +		/*
> +		 * TODO: check for which chip-sets we want to support DFS
> +		 */
> +		pCap->hw_caps |= ATH9K_HW_CAP_DFS;
> +	}
> +#endif
> +
>  	tx_chainmask = pCap->tx_chainmask;
>  	rx_chainmask = pCap->rx_chainmask;
>  	while (tx_chainmask || rx_chainmask) {

Regards,
	Chr