linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Jouni Malinen <j@w1.fi>
Cc: Arik Nemtsov <arik@wizery.com>,
	linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: init rate-control for TDLS sta when supp-rates are known
Date: Mon, 7 Nov 2011 13:11:35 -0500	[thread overview]
Message-ID: <20111107181135.GD2798@tuxdriver.com> (raw)
In-Reply-To: <20111027142248.GA3972@jm.kir.nu>

On Thu, Oct 27, 2011 at 05:22:48PM +0300, Jouni Malinen wrote:
> On Wed, Oct 26, 2011 at 03:47:46PM +0200, Arik Nemtsov wrote:
> > Initialize rate control algorithms only when supported rates are known
> > for a TDLS peer sta. Direct Tx between peers is not allowed before the
> > link is enabled. In turn, this only occurs after a change_station()
> > call that sets supported rates.
> 
> Thanks - this seems to fix the issues I saw previously. I tested ath9k
> with this instead of my earlier patch and was able to run successfully
> through my TDLS test scripts against another implementation.

I merged this patch from Jouni:

	commit e3a4cc2f073739c9c9c2e97efc774703061f034a
	Author: Jouni Malinen <j@w1.fi>
	Date:   Sun Oct 23 22:36:04 2011 +0300

	    mac80211: Fix TDLS support validation in add_station handler
    
	    We need to verify whether the command is successful before allocating
	    the station entry to avoid extra processing. This also fixes a memory
	    leak on the error path.
    
	    Signed-off-by: Jouni Malinen <j@w1.fi>
	    Signed-off-by: John W. Linville <linville@tuxdriver.com>

I'm not sure what to do with this patch now.  I think I will just drop
it, and you can send me a new patch that applies on top of Jouni's
(perhaps even reverting it) as appropriate?

Thanks,

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-11-07 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 13:47 [PATCH] mac80211: init rate-control for TDLS sta when supp-rates are known Arik Nemtsov
2011-10-27 14:22 ` Jouni Malinen
2011-11-07 18:11   ` John W. Linville [this message]
2011-11-07 21:22     ` Arik Nemtsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111107181135.GD2798@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=arik@wizery.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).