* Re: [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
[not found] <1320756132-14625-1-git-send-email-eyal@wizery.com>
@ 2011-11-08 12:47 ` Luciano Coelho
2011-11-08 14:08 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2011-11-08 12:47 UTC (permalink / raw)
To: Eyal Shapira, linville; +Cc: linux-wireless
On Tue, 2011-11-08 at 14:42 +0200, Eyal Shapira wrote:
> A minor fix for the check that verifies that all given SSIDs (in req) exist
> in the filters (the match sets)
>
> Signed-off-by: Eyal Shapira <eyal@wizery.com>
> ---
Acked-by: Luciano Coelho <coelho@ti.com>
John, can you apply this to 3.2, please?
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
2011-11-08 12:47 ` [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters Luciano Coelho
@ 2011-11-08 14:08 ` John W. Linville
0 siblings, 0 replies; 5+ messages in thread
From: John W. Linville @ 2011-11-08 14:08 UTC (permalink / raw)
To: Luciano Coelho; +Cc: Eyal Shapira, linux-wireless
On Tue, Nov 08, 2011 at 02:47:59PM +0200, Luciano Coelho wrote:
> On Tue, 2011-11-08 at 14:42 +0200, Eyal Shapira wrote:
> > A minor fix for the check that verifies that all given SSIDs (in req) exist
> > in the filters (the match sets)
> >
> > Signed-off-by: Eyal Shapira <eyal@wizery.com>
> > ---
>
> Acked-by: Luciano Coelho <coelho@ti.com>
>
> John, can you apply this to 3.2, please?
Can someone bounce me a fresh copy? :-)
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
@ 2011-11-08 13:54 Eyal Shapira
2011-11-08 14:06 ` Luciano Coelho
0 siblings, 1 reply; 5+ messages in thread
From: Eyal Shapira @ 2011-11-08 13:54 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless
A minor fix for the check that verifies that all given SSIDs (in req) exist
in the filters (the match sets)
Signed-off-by: Eyal Shapira <eyal@wizery.com>
---
drivers/net/wireless/wl12xx/scan.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
index 128ccb7..fc29c67 100644
--- a/drivers/net/wireless/wl12xx/scan.c
+++ b/drivers/net/wireless/wl12xx/scan.c
@@ -559,7 +559,7 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,
break;
}
/* Fail if SSID isn't present in the filters */
- if (j == req->n_ssids) {
+ if (j == cmd->n_ssids) {
ret = -EINVAL;
goto out_free;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
2011-11-08 13:54 Eyal Shapira
@ 2011-11-08 14:06 ` Luciano Coelho
2011-11-08 14:09 ` John W. Linville
0 siblings, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2011-11-08 14:06 UTC (permalink / raw)
To: Eyal Shapira, linville; +Cc: linux-wireless
On Tue, 2011-11-08 at 15:54 +0200, Eyal Shapira wrote:
> A minor fix for the check that verifies that all given SSIDs (in req) exist
> in the filters (the match sets)
>
> Signed-off-by: Eyal Shapira <eyal@wizery.com>
> ---
> drivers/net/wireless/wl12xx/scan.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
> index 128ccb7..fc29c67 100644
> --- a/drivers/net/wireless/wl12xx/scan.c
> +++ b/drivers/net/wireless/wl12xx/scan.c
> @@ -559,7 +559,7 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,
> break;
> }
> /* Fail if SSID isn't present in the filters */
> - if (j == req->n_ssids) {
> + if (j == cmd->n_ssids) {
> ret = -EINVAL;
> goto out_free;
> }
Just to clarify. My comment:
> Acked-by: Luciano Coelho <coelho@ti.com>
>
> John, can you apply this to 3.2, please?
...was about this patch. Eyal's email was delivered to me, but vger
rejected it, so he had to resend it.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters
2011-11-08 14:06 ` Luciano Coelho
@ 2011-11-08 14:09 ` John W. Linville
0 siblings, 0 replies; 5+ messages in thread
From: John W. Linville @ 2011-11-08 14:09 UTC (permalink / raw)
To: Luciano Coelho; +Cc: Eyal Shapira, linux-wireless
On Tue, Nov 08, 2011 at 04:06:28PM +0200, Luciano Coelho wrote:
> On Tue, 2011-11-08 at 15:54 +0200, Eyal Shapira wrote:
> > A minor fix for the check that verifies that all given SSIDs (in req) exist
> > in the filters (the match sets)
> >
> > Signed-off-by: Eyal Shapira <eyal@wizery.com>
> > ---
> > drivers/net/wireless/wl12xx/scan.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/wl12xx/scan.c b/drivers/net/wireless/wl12xx/scan.c
> > index 128ccb7..fc29c67 100644
> > --- a/drivers/net/wireless/wl12xx/scan.c
> > +++ b/drivers/net/wireless/wl12xx/scan.c
> > @@ -559,7 +559,7 @@ wl12xx_scan_sched_scan_ssid_list(struct wl1271 *wl,
> > break;
> > }
> > /* Fail if SSID isn't present in the filters */
> > - if (j == req->n_ssids) {
> > + if (j == cmd->n_ssids) {
> > ret = -EINVAL;
> > goto out_free;
> > }
>
> Just to clarify. My comment:
> > Acked-by: Luciano Coelho <coelho@ti.com>
> >
> > John, can you apply this to 3.2, please?
>
> ...was about this patch. Eyal's email was delivered to me, but vger
> rejected it, so he had to resend it.
OK, I got it. :-)
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-11-08 14:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1320756132-14625-1-git-send-email-eyal@wizery.com>
2011-11-08 12:47 ` [PATCH] wl12xx: fix wl12xx_scan_sched_scan_ssid_list() check that all given ssids are in filters Luciano Coelho
2011-11-08 14:08 ` John W. Linville
2011-11-08 13:54 Eyal Shapira
2011-11-08 14:06 ` Luciano Coelho
2011-11-08 14:09 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).