linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wpa_supplicant: Set configured auth_algs
@ 2011-11-11 15:02 Vasanthakumar Thiagarajan
  2011-11-12  9:00 ` Kalle Valo
  0 siblings, 1 reply; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-11-11 15:02 UTC (permalink / raw)
  To: j; +Cc: linux-wireless, Vasanthakumar Thiagarajan

In Ap mode, Authentication algorithm is reset in hostapd_config_defaults_bss() and
never be set to the configured one. This would pass the default
auth_algs (OPEN|SHARED) to driver and cause authentication isseues.

Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
---
 wpa_supplicant/ap.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/wpa_supplicant/ap.c b/wpa_supplicant/ap.c
index d08fc7c..dada412 100644
--- a/wpa_supplicant/ap.c
+++ b/wpa_supplicant/ap.c
@@ -140,6 +140,9 @@ static int wpa_supplicant_conf_ap(struct wpa_supplicant *wpa_s,
 	bss->ssid.ssid_len = ssid->ssid_len;
 	bss->ssid.ssid_set = 1;
 
+	if (ssid->auth_alg)
+		bss->auth_algs = ssid->auth_alg;
+
 	if (wpa_key_mgmt_wpa_psk(ssid->key_mgmt))
 		bss->wpa = ssid->proto;
 	bss->wpa_key_mgmt = ssid->key_mgmt;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wpa_supplicant: Set configured auth_algs
  2011-11-11 15:02 [PATCH] wpa_supplicant: Set configured auth_algs Vasanthakumar Thiagarajan
@ 2011-11-12  9:00 ` Kalle Valo
  2011-11-14  5:27   ` Vasanthakumar Thiagarajan
  0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2011-11-12  9:00 UTC (permalink / raw)
  To: Vasanthakumar Thiagarajan; +Cc: j, linux-wireless

Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> writes:

> In Ap mode, Authentication algorithm is reset in
> hostapd_config_defaults_bss() and never be set to the configured
> one. This would pass the default auth_algs (OPEN|SHARED) to driver
> and cause authentication isseues.

Shouldn't you send this to the hostap mailing list?

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] wpa_supplicant: Set configured auth_algs
  2011-11-12  9:00 ` Kalle Valo
@ 2011-11-14  5:27   ` Vasanthakumar Thiagarajan
  0 siblings, 0 replies; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-11-14  5:27 UTC (permalink / raw)
  To: Kalle Valo; +Cc: j, linux-wireless

On Sat, Nov 12, 2011 at 11:00:06AM +0200, Kalle Valo wrote:
> Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> writes:
> 
> > In Ap mode, Authentication algorithm is reset in
> > hostapd_config_defaults_bss() and never be set to the configured
> > one. This would pass the default auth_algs (OPEN|SHARED) to driver
> > and cause authentication isseues.
> 
> Shouldn't you send this to the hostap mailing list?

Oops, forgot it, as the ath6kl patch has a reference to this patch I added
linux-wireless list but missed to add the one meant for hostap. Thanks for
pointing this out.

Vasanth

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-11-14  5:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11 15:02 [PATCH] wpa_supplicant: Set configured auth_algs Vasanthakumar Thiagarajan
2011-11-12  9:00 ` Kalle Valo
2011-11-14  5:27   ` Vasanthakumar Thiagarajan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).