* Re: [PATCH] p54spi: Fix workqueue deadlock
[not found] <20111116235546.096975f6@milhouse>
@ 2011-11-16 23:07 ` Christian Lamparter
2011-11-17 0:04 ` Julian Calaby
0 siblings, 1 reply; 3+ messages in thread
From: Christian Lamparter @ 2011-11-16 23:07 UTC (permalink / raw)
To: Michael Büsch; +Cc: John W. Linville, linux-wireless
On Wednesday, November 16, 2011 11:55:46 PM Michael Büsch wrote:
> priv->work must not be synced while priv->mutex is locked, because
> the mutex is taken in the work handler.
> Move cancel_work_sync down to after the device shutdown code.
> This is safe, because the work handler checks fw_state and bails out
> early in case of a race.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
Cc: <stable@kernel.org>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] p54spi: Fix workqueue deadlock
2011-11-16 23:07 ` [PATCH] p54spi: Fix workqueue deadlock Christian Lamparter
@ 2011-11-17 0:04 ` Julian Calaby
2011-11-17 15:06 ` Christian Lamparter
0 siblings, 1 reply; 3+ messages in thread
From: Julian Calaby @ 2011-11-17 0:04 UTC (permalink / raw)
To: Christian Lamparter; +Cc: Michael Büsch, John W. Linville, linux-wireless
Christian, Michael,
I'm not sure these patches made it to the list.
Thanks,
Julian Calaby
On Thu, Nov 17, 2011 at 10:07, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> On Wednesday, November 16, 2011 11:55:46 PM Michael Büsch wrote:
>> priv->work must not be synced while priv->mutex is locked, because
>> the mutex is taken in the work handler.
>> Move cancel_work_sync down to after the device shutdown code.
>> This is safe, because the work handler checks fw_state and bails out
>> early in case of a race.
>>
>> Signed-off-by: Michael Buesch <m@bues.ch>
> Cc: <stable@kernel.org>
> Acked-by: Christian Lamparter <chunkeey@googlemail.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] p54spi: Fix workqueue deadlock
2011-11-17 0:04 ` Julian Calaby
@ 2011-11-17 15:06 ` Christian Lamparter
0 siblings, 0 replies; 3+ messages in thread
From: Christian Lamparter @ 2011-11-17 15:06 UTC (permalink / raw)
To: Julian Calaby; +Cc: Michael Büsch, John W. Linville, linux-wireless
On Thursday, November 17, 2011 01:04:49 AM Julian Calaby wrote:
> Christian, Michael,
>
> I'm not sure these patches made it to the list.
>
> Thanks,
You are right, but I don't know why? Michael can you please
resend the patch?
Regards,
Chr
> On Thu, Nov 17, 2011 at 10:07, Christian Lamparter
> <chunkeey@googlemail.com> wrote:
> > On Wednesday, November 16, 2011 11:55:46 PM Michael Büsch wrote:
> >> priv->work must not be synced while priv->mutex is locked, because
> >> the mutex is taken in the work handler.
> >> Move cancel_work_sync down to after the device shutdown code.
> >> This is safe, because the work handler checks fw_state and bails out
> >> early in case of a race.
> >>
> >> Signed-off-by: Michael Buesch <m@bues.ch>
> > Cc: <stable@kernel.org>
> > Acked-by: Christian Lamparter <chunkeey@googlemail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-17 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20111116235546.096975f6@milhouse>
2011-11-16 23:07 ` [PATCH] p54spi: Fix workqueue deadlock Christian Lamparter
2011-11-17 0:04 ` Julian Calaby
2011-11-17 15:06 ` Christian Lamparter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).