From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Kalle Valo <kvalo@adurom.com>,
Greg Dietsche <gregory.dietsche@cuw.edu>,
linux-wireless@vger.kernel.org
Subject: Re: pull request: iwlegacy 2011-11-16
Date: Fri, 18 Nov 2011 08:30:42 +0100 [thread overview]
Message-ID: <20111118073041.GA2203@redhat.com> (raw)
In-Reply-To: <20111117190307.GE32622@tuxdriver.com>
On Thu, Nov 17, 2011 at 02:03:08PM -0500, John W. Linville wrote:
> On Thu, Nov 17, 2011 at 09:36:44AM +0200, Kalle Valo wrote:
> > Stanislaw Gruszka <sgruszka@redhat.com> writes:
> >
> > > Please pull iwlegacy cleanup changes done by Greg and me, intended
> > > for 3.3. These request include huge patches with file renaming and
> > > automatic code processing done by sed and indent. Driver is still
> > > quite messy and need more cleanup, but these massive changes bring
> > > driver close to the state that we could name it maintainable.
> > >
> > > Hopefully with having clean, maintainable code I will be able to fix
> > > some nasty not easy reproducible bugs, we still have in the iwlegacy
> > > driver.
> >
> > I haven't seen these patches on linux-wireless mailing list at all.
I did not post them because most of them are big patches done by sed or
"git mv", nothing that would benefit from review.
> > Isn't it recommended that all wireless patches are sent to
> > linux-wireless for public review?
>
> Yes, it is. Please make sure to send these patches to the list for
> review by the group.
I'm going to post, but first I'll need to separate big patches and make
them available for download instead of posting mega bytes in email.
Anyway, if someone like to look at the patches, its better to just pull
github tree, or even clone it. It used with --reference option clone
will be fast, i.e:
git clone --reference linux-2.6 git://github.com/sgruszka/iwlegacy.git
Stanislaw
next prev parent reply other threads:[~2011-11-18 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 12:22 pull request: iwlegacy 2011-11-16 Stanislaw Gruszka
2011-11-17 7:36 ` Kalle Valo
2011-11-17 19:03 ` John W. Linville
2011-11-18 7:30 ` Stanislaw Gruszka [this message]
2011-11-21 15:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118073041.GA2203@redhat.com \
--to=sgruszka@redhat.com \
--cc=gregory.dietsche@cuw.edu \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).