From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>
Subject: Re: [PATCHv3 3/3] mac80211: Add NoAck per tid Support
Date: Fri, 18 Nov 2011 13:30:54 +0100 [thread overview]
Message-ID: <20111118123054.GA32175@pandem0nium> (raw)
In-Reply-To: <1321614744.10266.37.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On Fri, Nov 18, 2011 at 12:12:24PM +0100, Johannes Berg wrote:
> On Fri, 2011-11-18 at 12:01 +0100, Simon Wunderlich wrote:
>
> > - if (is_multicast_ether_addr(hdr->addr1))
> > + if (is_multicast_ether_addr(hdr->addr1) ||
> > + (sdata->noack_map & 1 << tid)) {
>
> I'd prefer this:
>
> if (is_multicast_ether_addr(...) ||
> sdata->noack_map & BIT(tid))
>
> (Note indentation & use of BIT())
OK
>
> Isn't this missing an update to ieee80211_duration() now?
Yep, I silently dropped that modification - I rather don't mess with stuff I
don't completly understand. Keeping the duration too long shouldn't hurt
(only performance), having it too short will have much worse effects ...
Thanks,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-11-18 12:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 11:01 [PATCHv3 0/3] add NoAck per tid support Simon Wunderlich
2011-11-18 11:01 ` [PATCHv3 1/3] mac80211: remove debugfs noack test Simon Wunderlich
2011-11-18 11:01 ` [PATCHv3 2/3] wireless: Add NoAck per tid Support Simon Wunderlich
2011-11-18 11:17 ` Johannes Berg
2011-11-18 11:01 ` [PATCHv3 3/3] mac80211: " Simon Wunderlich
2011-11-18 11:12 ` Johannes Berg
2011-11-18 12:30 ` Simon Wunderlich [this message]
2011-11-21 17:20 ` Kalle Valo
2011-11-21 17:26 ` Johannes Berg
2011-11-21 20:37 ` Simon Wunderlich
2011-11-18 11:01 ` [PATCHv3 1/2] iw: import latest nl80211.h with new commands Simon Wunderlich
2011-11-18 11:01 ` [PATCHv3 2/2] iw: add support for NoAck per tid Simon Wunderlich
2011-11-18 11:15 ` Johannes Berg
2011-11-18 11:55 ` Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118123054.GA32175@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox