Re: [PATCH] compat-wireless: avoid pr_fmt build SPAM

["John W. Linville" <linville@tuxdriver.com>]

On Fri, Nov 18, 2011 at 10:00:12PM +0100, Johannes Berg wrote:
> On Fri, 2011-11-18 at 15:54 -0500, John W. Linville wrote:
> > The way the compat-* header files are included causes the default
> > pr_fmt definition from <linux/kernel.h> to be evaluated for every file.
> > Files that define pr_fmt then generate a lot of build SPAM about
> > pr_fmt being redefined.
> > 
> > Eliminate the build noise by preemptively undefining pr_fmt in those
> > files that define it.  This is accomplished by adding a patch to the
> > patches directory.
> 
> This patch is going to be relatively painful when files move etc -- is
> that really worth it? I for one will just drop it in our compat version
> if it goes in since I don't even have all the files it patches :-)

I don't know how much those definitions will move, since they are
rooted to the tops of those files anyway.  If the files move or
whatever there will be some flux.  But then you'll be no worse-off
than we are now for that file, and hopefully only a few hunks will
have problems at any given time.

Personally, I hate seeing all those warnings fly-by.  It is even worse
when you know you are building backported code, where my experience
suggests that warnings are more likely to be revealing real problems.
Having all that SPAM about pr_fmt being redefined is just encouraging
us to ignore what might otherwise be legitimate warnings.

These hunks are one-liners that I predict will change rarely and
which are obvious to move or to add to new files.  I'd rather have
this patch than not.

John

P.S.  I'll see your threat to drop the patch at Intel and I'll raise
it with my threat to add the patch to Fedora. :-)
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.