From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:59782 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505Ab1KRWA3 (ORCPT ); Fri, 18 Nov 2011 17:00:29 -0500 Date: Fri, 18 Nov 2011 16:49:18 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: Johannes Berg , Julia Lawall , Jesper Andersen , linux-wireless@vger.kernel.org, Hauke Mehrtens Subject: Re: [PATCH] compat-wireless: avoid pr_fmt build SPAM Message-ID: <20111118214917.GA29042@tuxdriver.com> (sfid-20111118_230032_989344_F60CE22F) References: <1321649673-15874-1-git-send-email-linville@tuxdriver.com> <1321650012.10266.78.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Nov 18, 2011 at 01:12:51PM -0800, Luis R. Rodriguez wrote: > On Fri, Nov 18, 2011 at 1:00 PM, Johannes Berg > wrote: > > On Fri, 2011-11-18 at 15:54 -0500, John W. Linville wrote: > >> The way the compat-* header files are included causes the default > >> pr_fmt definition from to be evaluated for every file. > >> Files that define pr_fmt then generate a lot of build SPAM about > >> pr_fmt being redefined. > >> > >> Eliminate the build noise by preemptively undefining pr_fmt in those > >> files that define it.  This is accomplished by adding a patch to the > >> patches directory. > > > > This patch is going to be relatively painful when files move etc -- is > > that really worth it? I for one will just drop it in our compat version > > if it goes in since I don't even have all the files it patches :-) > > This may be a good use case for spatch magic? Yeah, I was thinking exactly that. I haven't tried spatch yet, but it would probably handle this fairly well. Are you using it anywhere else? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.