From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cantor2.suse.de ([195.135.220.15]:38176 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757839Ab1KSAIW (ORCPT ); Fri, 18 Nov 2011 19:08:22 -0500 Message-Id: <20111119000005.478187691@clark.kroah.org> (sfid-20111119_011920_827588_47100DE3) Date: Fri, 18 Nov 2011 15:58:30 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, greg@kroah.com Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, roman-vl@meta.ua, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [17/26] b43: refuse to load unsupported firmware In-Reply-To: <20111119000026.GA6679@kroah.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: 3.0-stable review patch. If anyone has any objections, please let me know. ------------------ [This patch is supposed to be applied in 3.1 (and maybe older) branches only.] New kernels support newer firmware that users may try to incorrectly use with older kernels. Display error and explain the problem in such a case Signed-off-by: Rafał Miłecki Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/b43/main.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/net/wireless/b43/main.c +++ b/drivers/net/wireless/b43/main.c @@ -2401,6 +2401,13 @@ static int b43_upload_microcode(struct b b43_print_fw_helptext(dev->wl, 1); err = -EOPNOTSUPP; goto error; + } else if (fwrev >= 598) { + b43err(dev->wl, "YOUR FIRMWARE IS TOO NEW. Support for " + "firmware 598 and up requires kernel 3.2 or newer. You " + "have to install older firmware or upgrade kernel.\n"); + b43_print_fw_helptext(dev->wl, 1); + err = -EOPNOTSUPP; + goto error; } dev->fw.rev = fwrev; dev->fw.patch = fwpatch;