From: Matthew Garrett <mjg@redhat.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: platform-driver-x86@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
"Martin Večeřa" <ja@marvec.org>,
"Alejandro Vidal Mata" <alex14@gmail.com>,
"Javier Vidal Mata" <javitu@gmail.com>,
"Tino Schmidt" <mailtinoshomepage@gmx.net>,
"Johannes Berg" <johannes@sipsolutions.net>,
631664@bugs.debian.org
Subject: Re: [PATCH v2] x86: Add amilo-rfkill driver for some Fujitsu-Siemens Amilo laptops
Date: Tue, 22 Nov 2011 19:30:44 +0000 [thread overview]
Message-ID: <20111122193044.GE5163@srcf.ucam.org> (raw)
In-Reply-To: <1321211202.18929.295.camel@deadeye>
On Sun, Nov 13, 2011 at 07:06:42PM +0000, Ben Hutchings wrote:
> +#define A1655_STATE_PORT 0x64
> +#define A1655_COMMAND_PORT 0x64
> +#define A1655_DATA_PORT 0x60
You'll need to synchronise with the i8042 driver here, otherwise things
could go horribly wrong.
> +#define M7440_PORT1 0x118f
> +#define M7440_PORT2 0x118e
These ports are defined in the DSDT for one of these systems, but not
referenced. I think a hardware-banging driver like this is probably the
only interface.
Should be fine as long as you make sure you're not racing with the
keyboard controller.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-22 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 19:06 [PATCH v2] x86: Add amilo-rfkill driver for some Fujitsu-Siemens Amilo laptops Ben Hutchings
2011-11-22 19:30 ` Matthew Garrett [this message]
2011-11-25 4:09 ` [PATCH v3] " Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122193044.GE5163@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=631664@bugs.debian.org \
--cc=alex14@gmail.com \
--cc=ben@decadent.org.uk \
--cc=ja@marvec.org \
--cc=javitu@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mailtinoshomepage@gmx.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).