From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Senthil Balasubramanian <senthilb@qca.qualcomm.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Adrian Chadd <adrian@freebsd.org>
Subject: [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One
Date: Sat, 26 Nov 2011 23:37:43 +0100 [thread overview]
Message-ID: <201111262337.43771.rjw@sisk.pl> (raw)
In-Reply-To: <201111262232.46195.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Revert a hunk in drivers/net/wireless/ath/ath9k/hw.c introduced by
commit 2577c6e8f2320f1d2f09be122efef5b9118efee4 (ath9k_hw: Add
support for AR946/8x chipsets) that caused a nasty regression to
appear on my Acer Ferrari One (the box locks up entirely at random
times after the wireless has been started without any way to get
debug information out of it).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/net/wireless/ath/ath9k/hw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux/drivers/net/wireless/ath/ath9k/hw.c
===================================================================
--- linux.orig/drivers/net/wireless/ath/ath9k/hw.c
+++ linux/drivers/net/wireless/ath/ath9k/hw.c
@@ -1827,7 +1827,8 @@ static void ath9k_set_power_sleep(struct
}
/* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */
- REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
+ if (AR_SREV_9300_20_OR_LATER(ah))
+ REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE);
}
/*
next prev parent reply other threads:[~2011-11-26 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFyNUC+k1gp3MQkxQzernEzRZwYOH4EBnOq=6UiaJ2oh4A@mail.gmail.com>
[not found] ` <201111250203.29786.rjw@sisk.pl>
2011-11-26 21:32 ` [Regression, 3.2-rc1] ath9k broken on AR928X (was: Re: Linux 3.2-rc3 - just in time for Thanksgiving) Rafael J. Wysocki
2011-11-26 21:54 ` Adrian Chadd
2011-11-26 22:37 ` Rafael J. Wysocki [this message]
2011-11-27 1:16 ` [PATCH] ath9k: Revert change that broke AR928X on Acer Ferrari One Adrian Chadd
2011-11-27 6:25 ` Felix Fietkau
2011-11-27 6:39 ` Adrian Chadd
2011-11-27 6:20 ` [Regression, 3.2-rc1] ath9k broken on AR928X Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111262337.43771.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=adrian@freebsd.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@qca.qualcomm.com \
--cc=senthilb@qca.qualcomm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).