From: Daniel Golle <dgolle@allnet.de>
To: <linux-wireless@vger.kernel.org>
Cc: Daniel Golle <dgolle@allnet.de>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Johannes Berg <johannes.berg@intel.com>,
Felix Fietkau <nbd@openwrt.org>
Subject: [PATCH v1 0/3] support for antenna configuration profiles
Date: Mon, 28 Nov 2011 17:12:25 +0100 [thread overview]
Message-ID: <20111128161225.GA25430@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]
Hi!
It took me a while to get this into a nice shape and make the code less hackish.
Thank you for all the helpful feedback on PATCH v0 and the RFC!
I'm looking forward to your comments and highly appreciate any further advise.
Changes since my previous patch:
* restructured nl80211 stuff, putting the whole thing into a NLA_NESTED makes
the parser happy.
* store selection state in the driver instead of overwriting the value in the
AntCtrlCommon field.
* expose selected switch_com_value in eeprom_4k.
* moved stuff in ath9k to where it belongs (afaik)
* lots of cosmetics
I got my patched-up version of iw and works like a charm with the ALL0258N now:
root@OpenWrt:/# iw list
Wiphy phy0:
Band 1:
...
Device supports antenna configuration profiles.
(*) 0 horiz (horizontal TX, vertical RX)
( ) 1 vert (vertical TX, horizontal RX)
...
root@OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump
0x009964 0x00000000
root@OpenWrt:/# iw phy phy0 interface add wlan0 type station
root@OpenWrt:/# ifconfig wlan0 up
root@OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump
0x009964 0x09a00210
root@OpenWrt:/# ifconfig wlan0 down
root@OpenWrt:/# iw set extant 1
root@OpenWrt:/# iw list
Wiphy phy0
Band 1:
...
Device supports antenna configuration profiles.
( ) 0 horiz (horizontal TX, vertical RX)
(*) 1 vert (vertical TX, horizontal RX)
...
root@OpenWrt:/# ifconfig wlan0 up
root@OpenWrt:/# grep 9964 /sys/kernel/debug/ieee80211/phy0/ath9k/regdump
0x009964 0x0a900120
Here the patch for iw. I'm planing to partially reimplement that in libiwinfo
for OpenWrt's LuCI.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-11-28 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:12 Daniel Golle [this message]
2011-11-28 16:52 ` [PATCH v1 0/3] support for antenna configuration profiles Johannes Berg
2011-11-29 11:52 ` Daniel Golle
2011-11-30 8:57 ` Johannes Berg
2011-12-03 14:07 ` Daniel Golle
2011-11-29 13:52 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128161225.GA25430@localhost \
--to=dgolle@allnet.de \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).