From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
Alexander Simon <an.alexsimon@googlemail.com>,
Marek Lindner <lindner_marek@yahoo.de>,
Felix Fietkau <nbd@openwrt.org>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [PATCH 2/4] nl80211: Parse channel type attribute in an ibss join request
Date: Wed, 30 Nov 2011 13:27:31 +0100 [thread overview]
Message-ID: <20111130122731.GA14283@pandem0nium> (raw)
In-Reply-To: <1322655406.3982.12.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
Hey Johannes,
On Wed, Nov 30, 2011 at 01:16:46PM +0100, Johannes Berg wrote:
> On Mon, 2011-11-28 at 18:55 +0100, Simon Wunderlich wrote:
> > Prepare cfg80211 for IBSS HT:
> > * extend cfg80211 ibss struct with channel_type
> > * Check if extension channel can be used
> > * Export can_beacon_sec_chan for use in mac80211 (will be called
> > from ibss.c later).
>
> I'm thinking there should be a "driver supports HT IBSS" flag, and we
> reject the config otherwise?
There is already an implicit check for this - rdev_freq_to_chan() checks
if the channel_type is supported, and -EINVAL otherwise. So if I call
ibss_join with HT20 or HT40 on ath5k, it gets rejected already.
If this is not enough and we need a further flag, could you please give
me a hint how/where to implement it?
regards,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-11-30 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 17:55 [PATCH 0/4] add HT support for IBSS Simon Wunderlich
2011-11-28 17:55 ` [PATCH 1/4] mac80211: fill rate filter for internal scan requests Simon Wunderlich
2011-11-28 18:10 ` Johannes Berg
2011-11-28 17:55 ` [PATCH 2/4] nl80211: Parse channel type attribute in an ibss join request Simon Wunderlich
2011-11-30 12:16 ` Johannes Berg
2011-11-30 12:27 ` Simon Wunderlich [this message]
2011-11-30 12:30 ` Johannes Berg
2011-11-28 17:55 ` [PATCH 3/4] mac80211: Add HT operation modes for IBSS Simon Wunderlich
2011-11-28 17:55 ` [PATCH 4/4] mac80211: handle protection mode, RIFS and ADDBA for HT IBSS Simon Wunderlich
2011-11-30 12:16 ` Johannes Berg
2011-11-30 12:42 ` Simon Wunderlich
2011-11-28 17:55 ` [PATCH] iw: add HT options for ibss Simon Wunderlich
2011-11-30 11:32 ` [PATCH 0/4] add HT support for IBSS Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130122731.GA14283@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=an.alexsimon@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=lindner_marek@yahoo.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=nbd@openwrt.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox