linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [3.2-rc3] 100% CPU usage while in del_timer_sync from iwl3945_rs_free_sta
Date: Wed, 30 Nov 2011 16:39:30 +0100	[thread overview]
Message-ID: <20111130153929.GA2144@redhat.com> (raw)
In-Reply-To: <20111130140316.GA4153@tiehlicka.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

On Wed, Nov 30, 2011 at 03:03:16PM +0100, Michal Hocko wrote:
> No, didn't help unfortunately...

Lets gather some more messages. Please apply attached simple patch,
recompile with:
CONFIG_MAC80211_DEBUG_MENU=y
CONFIG_MAC80211_VERBOSE_DEBUG=y
and provide dmesg.

Thanks
Stanislaw

[-- Attachment #2: mac80211_debug.patch --]
[-- Type: text/plain, Size: 887 bytes --]

diff --git a/drivers/net/wireless/iwlegacy/iwl-3945-rs.c b/drivers/net/wireless/iwlegacy/iwl-3945-rs.c
index 8faeaf2..c728f94 100644
--- a/drivers/net/wireless/iwlegacy/iwl-3945-rs.c
+++ b/drivers/net/wireless/iwlegacy/iwl-3945-rs.c
@@ -413,6 +413,7 @@ static void *iwl3945_rs_alloc_sta(void *iwl_priv, struct ieee80211_sta *sta, gfp
 	IWL_DEBUG_RATE(priv, "enter\n");
 
 	rs_sta = &psta->rs_sta;
+	printk("%s rs_sta %p\n", __func__, rs_sta);
 
 	spin_lock_init(&rs_sta->lock);
 	init_timer(&rs_sta->rate_scale_flush);
@@ -432,6 +433,10 @@ static void iwl3945_rs_free_sta(void *iwl_priv, struct ieee80211_sta *sta,
 	 * to use iwl_priv to print out debugging) since it may not be fully
 	 * initialized at this point.
 	 */
+
+	printk("%s rs_sta %p\n", __func__, rs_sta);
+	if (WARN_ON(rs_sta->rate_scale_flush.base == NULL))
+		return;
 	del_timer_sync(&rs_sta->rate_scale_flush);
 }
 

  reply	other threads:[~2011-11-30 15:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 10:07 [3.2-rc3] 100% CPU usage while in del_timer_sync from iwl3945_rs_free_sta Michal Hocko
2011-11-29 11:39 ` Stanislaw Gruszka
2011-11-30 10:10   ` Michal Hocko
2011-11-30 14:23     ` Stanislaw Gruszka
2011-11-30 14:03       ` Michal Hocko
2011-11-30 15:39         ` Stanislaw Gruszka [this message]
2011-12-01  8:58           ` Michal Hocko
2011-12-01 10:55             ` Michal Hocko
2011-12-01 11:59               ` Stanislaw Gruszka
2011-12-01 12:44                 ` Michal Hocko
2011-12-01 12:55                   ` Stanislaw Gruszka
2011-12-01 13:13                     ` Eliad Peller
2011-12-01 13:31                       ` Stanislaw Gruszka
2011-12-01 13:37                       ` Sedat Dilek
2011-12-01 14:05                   ` Michal Hocko
2011-12-01 14:23                     ` Eliad Peller
2011-12-01 15:45                       ` John W. Linville
2011-12-01 12:04               ` Yong Zhang
2011-12-01 12:42                 ` Michal Hocko
2011-12-01  2:09 ` Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130153929.GA2144@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).