From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: Paul Stewart <pstew@google.com>,
"Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Senthil Balasubramanian <senthilb@qca.qualcomm.com>
Subject: Re: [PATCH 2/4] ath9k: rework power state handling
Date: Tue, 6 Dec 2011 15:04:34 -0500 [thread overview]
Message-ID: <20111206200434.GE30288@tuxdriver.com> (raw)
In-Reply-To: <4EC44CC6.7090104@openwrt.org>
On Thu, Nov 17, 2011 at 12:52:38AM +0100, Felix Fietkau wrote:
> On 2011-11-16 7:40 PM, Paul Stewart wrote:
> > In fact, could this be made contingent on whether there's an AP-mode
> > interface, since the problem you're encountering seems to only be in
> > AP mode? What troubles me, Felix, is your statement that " this
> > series fixes some "PCI error" crashes". Does this mean that you
> > haven't root-caused the problem, and that this may only partially mask
> > it?
> The existing code was wrong, especially for client mode. I only noticed
> that because I was investigating some AP mode crashes triggered by it.
> My main focus when fixing this stuff was actually client mode since
> that's the one most affected by this codepath.
Are we satisfied w/ this series? Or does it still need work?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-12-06 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 12:08 [PATCH 1/4] ath9k: always issue a full hw reset after waking up from full-sleep mode Felix Fietkau
2011-11-16 12:08 ` [PATCH 2/4] ath9k: rework power state handling Felix Fietkau
2011-11-16 12:08 ` [PATCH 3/4] ath9k: only drop packets in drv_flush when asked to Felix Fietkau
2011-11-16 12:08 ` [PATCH 4/4] ath9k: cancel all workqueue activity when going idle Felix Fietkau
2011-11-16 17:42 ` [PATCH 2/4] ath9k: rework power state handling Luis R. Rodriguez
2011-11-16 18:16 ` Felix Fietkau
2011-11-16 18:23 ` Luis R. Rodriguez
2011-11-16 18:40 ` Paul Stewart
2011-11-16 23:52 ` Felix Fietkau
2011-12-06 20:04 ` John W. Linville [this message]
2011-12-06 20:20 ` Paul Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206200434.GE30288@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@qca.qualcomm.com \
--cc=nbd@openwrt.org \
--cc=pstew@google.com \
--cc=senthilb@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).