linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: 李刚 <gang.li@watchdata.com>
To: "'Daniel Smith'" <viscous.liquid@gmail.com>,
	<linux-wireless@vger.kernel.org>
Subject: RE: Question about IEEE80211_TX_CTL_NO_ACK in ath_9k
Date: Mon, 19 Dec 2011 21:00:22 +0800	[thread overview]
Message-ID: <20111219125052.3B5A42005C@mail.watchdata.com.cn> (raw)
In-Reply-To: <jcnavc$psk$1@dough.gmane.org>

> 
> Hi!
> 
> On 12/19/2011 6:38 AM, 李刚 wrote:
> > Hi everybody!
> >
> > My wireless card is AR9280. I set the IEEE80211_TX_CTL_NO_ACK flag
before
> > send a packet, but found it no use. It still wait for an ACK. Then I
read
> > the code,
> > in ath9k_htc_tx_data(htc_drv_txrx.c) , it seems there is only two flags:
> >
> > #define ATH9K_HTC_TX_CTSONLY      0x1
> > #define ATH9K_HTC_TX_RTSCTS       0x2
> >
> > None is about ack.
> >
> > Does anyone know how to make this flag work properly?
> >
> 
> As an FYI if your card is a AR9280, then you should be looking in xmit.c
> and not at the HTC related code.

Hi, Daniel, Thanks you !

Sorry,  I didn't make it clear!  My 9280 is an USB card, so the related code
is htc_drv_*.c.



> 
> I am also working on this issue to enable per-frame no-ack and have
> already tracked it down to the following snippet in the function
> ieee80211_tx_prepare (mac80211/tx.c).
> 
> if (is_multicast_ether_addr(hdr->addr1)) {
> tx->flags &= ~IEEE80211_TX_UNICAST;
> info->flags |= IEEE80211_TX_CTL_NO_ACK;
> } else {
> tx->flags |= IEEE80211_TX_UNICAST;
> if (unlikely(local->wifi_wme_noack_test))
> info->flags |= IEEE80211_TX_CTL_NO_ACK;
> else
> info->flags &= ~IEEE80211_TX_CTL_NO_ACK;
> }

I have seen these codes in tx.c,  and at first I thought it should work, but
does not.


> 
> So if you send a unicast frame without this wifi_wme_noack_test flag set
> then mac80211 will force the frame to require an ACK. To set the flag,
> 
> # sudo -s "echo 1> /sys/kernel/debug/ieee80211/phy0/noack"
> 
> Assuming phy0 is the wireless card with which you are wanting to do the
> frame injection. The downside to this is that now every frame is passed
> to ath9k with the no ack flag set.
> 
> Daniel
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2011-12-19 13:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 23:18 Question about TCP Checksum errors Larry Finger
2011-12-17 23:43 ` Eric Dumazet
2011-12-19 11:38 ` Question about IEEE80211_TX_CTL_NO_ACK in ath_9k 李刚
2011-12-19 12:33   ` Mohammed Shafi
2011-12-19 13:03     ` 李刚
2011-12-19 12:33   ` Daniel Smith
2011-12-19 13:00     ` 李刚 [this message]
2011-12-19 13:43       ` Daniel Smith
2011-12-30  8:15         ` Question: ieee80211_rx called twice after one ieee80211_subif_start_xmit call 李刚
2011-12-30  9:30           ` Adrian Chadd
2012-01-07  2:11         ` Question about duration of data frame in ath9k_htc 李刚
2012-01-07  5:31           ` Sujith Manoharan
2011-12-19 13:07   ` Question about IEEE80211_TX_CTL_NO_ACK in ath_9k Helmut Schaa
2011-12-19 14:42   ` Sujith
2011-12-20  5:39     ` 李刚
2011-12-20 15:24       ` Sujith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219125052.3B5A42005C@mail.watchdata.com.cn \
    --to=gang.li@watchdata.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=viscous.liquid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).