From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: brcm: list of smatch warnings
Date: Wed, 21 Dec 2011 21:19:03 +0300 [thread overview]
Message-ID: <20111221181902.GG26771@mwanda> (raw)
In-Reply-To: <4EF21BA1.3020806@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
On Wed, Dec 21, 2011 at 06:47:13PM +0100, Arend van Spriel wrote:
> On 12/15/2011 12:29 PM, Dan Carpenter wrote:
> > Smatch still complains about the brcm driver. Could you take a look at
> > these messages? It's mostly just cleanups like doing the correct cast
> > for min_t() or handling the default cases on switch statements etc or
> > verifying that we broke out of a loop instead of coming to the end
> > without finding what we were looking for.
>
> As promised I took a look at the smatch complaints.
>
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1710 wlc_phy_txpower_reg_limit_calc(50) error: potential null derefence 'txpwr_ptr1'.
> > drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +1719 wlc_phy_txpower_reg_limit_calc(59) error: potential null derefence 'txpwr_ptr2'.
>
> However, I am not sure about these two. Reading the code these seem
> false positives. Could you confirm or correct me on these.
Yes. You're obviously right.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-21 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 11:29 brcm: list of smatch warnings Dan Carpenter
2011-12-15 11:40 ` Arend van Spriel
2011-12-21 17:47 ` Arend van Spriel
2011-12-21 18:19 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221181902.GG26771@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arend@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).