linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Yinghai Lu <yinghai@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-wireless@vger.kernel.org,
	Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: iwl3945 didn't survive after s2ram failure
Date: Thu, 5 Jan 2012 15:19:13 +0100	[thread overview]
Message-ID: <20120105141913.GA3937@tiehlicka.suse.cz> (raw)
In-Reply-To: <20120105110744.GA2222@redhat.com>

On Thu 05-01-12 12:07:45, Stanislaw Gruszka wrote:
[...]
> Only interesting thing we do while resume in the driver is:
> pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00); 
> we do the same during erly stage of .probe function too.
> 
> In the RH bugzilla case, it was regression. There are no iwlegacy
> changes between mentioned kernel versions. There are some APCI and pci
> changes. Can you try if any of these kernel boot parameters helps:
> pcie_aspm=off
> pcie_aspm=force
> pci=nocsr
> pci=use_csr

OK, so I have tried to boot with pcie_aspm=off and the wireless
resurrect. The I found out that I booted into 3.2 rather than 3.2-rc6 so
I retested with the original kernel and guess what, yes it reported the
same problem as before (with or without parameter). 
So I have tried to retest with few kernels (3.2.0-rc5,
3.2.0-rc6-00005-ga36bfdd, 3.2.0-rc7-00083-g115e8e7 and 3.2.0) that I
still had on my machine and 3.2.0-rc6-00005-ga36bfdd seems to be the
only affected one.
There doesn't seem to be any obvious difference wrt. the driver in the
logs (attached).

Looking in the history it seems that 497f16f2 [pci: Fix hotplug of
Express Module with pci bridges] might be related. It fixes an issue
introduced by bbef98ab [PCI: defer enablement of SRIOV BARS] which is a
part of my 3.2.0-rc6-00005-ga36bfdd problematic version. But I do not
understand details of the patch so I cannot tell that for 100%.
Yinghai Lu, is it possible that I the problem I have seen is somehow
related? For reference the thread started at
https://lkml.org/lkml/2011/12/27/65

Thanks
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

  reply	other threads:[~2012-01-05 14:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 10:53 iwl3945 didn't survive after s2ram failure Michal Hocko
2012-01-03 10:34 ` Stanislaw Gruszka
2012-01-03 12:23   ` Stanislaw Gruszka
2012-01-03 13:07     ` Michal Hocko
2012-01-05 11:26       ` Stanislaw Gruszka
2012-01-05 12:20         ` Michal Hocko
2012-01-03 13:03   ` Michal Hocko
2012-01-05 11:07     ` Stanislaw Gruszka
2012-01-05 14:19       ` Michal Hocko [this message]
2012-01-05 14:34         ` Michal Hocko
2012-01-05 15:00         ` Stanislaw Gruszka
2012-01-05 16:25           ` Michal Hocko
2012-01-05 19:44         ` Yinghai Lu
2012-01-06  8:49           ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105141913.GA3937@tiehlicka.suse.cz \
    --to=mhocko@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).