Linux wireless drivers development
 help / color / mirror / Atom feed
From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Eliad Peller <eliad@wizery.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: update oper_channel on ibss join
Date: Tue, 10 Jan 2012 18:52:07 +0100	[thread overview]
Message-ID: <20120110175207.GC19790@pandem0nium> (raw)
In-Reply-To: <1326201594-4748-1-git-send-email-eliad@wizery.com>

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

Hello Eliad,

this looks right, this line seems to be accidently removed - although
it also (accidently?) worked while I did my tests. :)

Anyway, thanks!

Acked-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>

On Tue, Jan 10, 2012 at 03:19:54PM +0200, Eliad Peller wrote:
> Commit 13c40c5 ("mac80211: Add HT operation modes for IBSS") broke
> ibss operation by mistakenly removing the local->oper_channel
> update (causing ibss to start on the wrong channel). fix it.
> 
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
>  net/mac80211/ibss.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index f8a32bf..765072d 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -106,6 +106,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
>  
>  	sdata->drop_unencrypted = capability & WLAN_CAPABILITY_PRIVACY ? 1 : 0;
>  
> +	local->oper_channel = chan;
>  	channel_type = ifibss->channel_type;
>  	if (channel_type > NL80211_CHAN_HT20 &&
>  	    !cfg80211_can_beacon_sec_chan(local->hw.wiphy, chan, channel_type))
> -- 
> 1.7.6.401.g6a319
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2012-01-10 17:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-10 13:19 [PATCH] mac80211: update oper_channel on ibss join Eliad Peller
2012-01-10 17:52 ` Simon Wunderlich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120110175207.GC19790@pandem0nium \
    --to=simon.wunderlich@s2003.tu-chemnitz.de \
    --cc=eliad@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox