From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>
Subject: Re: [PATCH 2/2] iw: remove ifdefs for mcs mask
Date: Tue, 10 Jan 2012 19:29:24 +0100 [thread overview]
Message-ID: <20120110182924.GD19790@pandem0nium> (raw)
In-Reply-To: <1326114339.3451.26.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Hey Johannes,
On Mon, Jan 09, 2012 at 02:05:39PM +0100, Johannes Berg wrote:
> On Thu, 2012-01-05 at 20:58 +0100, Simon Wunderlich wrote:
> > These are enums, not defines. Therefore the ifdef check can never be
> > true.
>
> The original idea was that in nl80211.h you do
>
> #define FOO FOO
Oh, ok, sorry, that's right, I haven't thought about this.
>
> (like we already have for a few things) to trigger the ifdef, but I
> don't really care.
I could as well add it into nl80211.h, and we skip this patch, or we remove
these ifdefs - your choice. :)
However, I don't think we really need the ifdefs as a copy of the nl80211.h
seems to be delivered with the iw source code anyway ...?
Cheers,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-10 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 19:58 [PATCHv2 0/2] add support for mcs masks Simon Wunderlich
2012-01-05 19:58 ` [PATCHv2 1/2] nl80211: " Simon Wunderlich
2012-01-09 13:01 ` Johannes Berg
2012-01-05 19:58 ` [PATCHv2 2/2] mac80211: " Simon Wunderlich
2012-01-09 13:04 ` Johannes Berg
2012-01-10 17:28 ` Simon Wunderlich
2012-01-10 17:35 ` Johannes Berg
2012-01-10 18:42 ` Simon Wunderlich
2012-01-05 19:58 ` [PATCH 1/2] iw: add nl80211 bitrates Simon Wunderlich
2012-01-05 19:58 ` [PATCH 2/2] iw: remove ifdefs for mcs mask Simon Wunderlich
2012-01-09 13:05 ` Johannes Berg
2012-01-10 18:29 ` Simon Wunderlich [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-28 16:25 [PATCHv3 0/2] [RESEND] add support for mcs masks Simon Wunderlich
2012-01-28 16:25 ` [PATCH 2/2] iw: remove ifdefs for mcs mask Simon Wunderlich
2011-12-19 14:14 [PATCH 0/2] add support for mcs masks Simon Wunderlich
2011-12-19 14:14 ` [PATCH 2/2] iw: remove ifdefs for mcs mask Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110182924.GD19790@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox