linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, 656813@bugs.debian.org
Subject: Re: [PATCH 1/2] ipw2200: Fix order of device registration
Date: Mon, 23 Jan 2012 12:05:45 +0100	[thread overview]
Message-ID: <20120123110543.GA3637@redhat.com> (raw)
In-Reply-To: <1327201775.8004.83.camel@deadeye>

Hi Ben

On Sun, Jan 22, 2012 at 03:09:35AM +0000, Ben Hutchings wrote:
> Currently cfg80211 fails to create a "phy80211" symlink in sysfs from
> the net device to the wiphy device.  The latter needs to be registered
> first.
> 
> Compile-tested only.
> 
> Reported-by: Cesare Leonardi <celeonar@gmail.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

This problem was created by my changes (commit
7cabafcea793c003503a118da58da358b0692930). I was aware of remove
symlink, and I'm sorry for that, but I think this symlink is not
necessary, i.e: dereferencing device/ieee80211/phy0 give the same
data:

[root@dhcp-27-172 wlan0]# readlink -f phy80211
/sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/ieee80211/phy0
[root@dhcp-27-172 wlan0]# readlink -f device
/sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0

Of course user space application may relay on the link, but well
fixing that in kernel is not so easy as it looks at first glace.
Reverting commits causing this problem, will remove fix for
another quite serious issue. Changing ipw2x00 or mac80211 is
risky, as that initalization code is kinda fragile. The best way
for fix, is change applications that relay on that link.

Thanks
Stanislaw

      parent reply	other threads:[~2012-01-23 11:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-22  3:09 [PATCH 1/2] ipw2200: Fix order of device registration Ben Hutchings
2012-01-22  3:11 ` [PATCH 2/2] ipw2100: " Ben Hutchings
2012-01-22  3:32 ` [PATCH 1/2] ipw2200: " Stefan Lippers-Hollmann
2012-01-22  4:18   ` Ben Hutchings
2012-01-23 11:05 ` Stanislaw Gruszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120123110543.GA3637@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=656813@bugs.debian.org \
    --cc=ben@decadent.org.uk \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).