linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Andreas Hartmann <andihartmann@01019freenet.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Felix Fietkau <nbd@openwrt.org>
Subject: Re: Compat-wireless-3.2-rc6-3 is broken for rt2860 device
Date: Tue, 24 Jan 2012 08:29:46 +0100	[thread overview]
Message-ID: <20120124072946.GB2420@redhat.com> (raw)
In-Reply-To: <CAGXE3d_rCMYwoEBNjk+S7WvAmCkPMcq-Gpawm370-cSbjXy6rg@mail.gmail.com>

On Mon, Jan 23, 2012 at 02:29:08PM +0100, Helmut Schaa wrote:
> On Fri, Jan 20, 2012 at 8:29 AM, Andreas Hartmann
> <andihartmann@01019freenet.de> wrote:
> > All in one: Your workaround was a good idea, but unfortunately it
> > doesn't "solve" / workaround the problem introduced with the patch
> > "mac80211: retry sending failed BAR frames later instead of tearing
> > down aggr" [1]. I don't know off any other solution at this time as to revert it.
> 
> Ok, so we've got at least one hw issue here: rt2800 is not able to report
> correct ACK state of BARs :(

Whould it help, if rt2800 driver will not filter out BAR frames?

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 22a1a8f..20418be 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -1205,8 +1205,7 @@ void rt2800_config_filter(struct rt2x00_dev *rt2x00dev,
 			   !(filter_flags & FIF_PSPOLL));
 	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BA,
 			   !(filter_flags & FIF_CONTROL));
-	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BAR,
-			   !(filter_flags & FIF_CONTROL));
+	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BAR, 0);
 	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_CNTL,
 			   !(filter_flags & FIF_CONTROL));
 	rt2800_register_write(rt2x00dev, RX_FILTER_CFG, reg);



  parent reply	other threads:[~2012-01-24  7:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-31 13:49 Compat-wireless-3.2-rc6-3 is broken for rt2860 device Andreas Hartmann
2011-12-31 20:35 ` Andreas Hartmann
2012-01-03 21:51   ` Helmut Schaa
2012-01-04  8:38     ` Andreas Hartmann
2012-01-04 15:04       ` Helmut Schaa
2012-01-05  8:44         ` Andreas Hartmann
2012-01-09 10:23           ` Helmut Schaa
2012-01-09 13:29             ` Andreas Hartmann
2012-01-09 13:45               ` Helmut Schaa
2012-01-10  8:03                 ` Andreas Hartmann
2012-01-10  9:50                   ` Helmut Schaa
2012-01-10 11:56                     ` Andreas Hartmann
2012-01-10 12:23                       ` Helmut Schaa
2012-01-10 13:01                         ` Andreas Hartmann
2012-01-10 13:43                           ` Helmut Schaa
2012-01-10 14:41                             ` Andreas Hartmann
2012-01-17  9:09                     ` Andreas Hartmann
2012-01-20  7:29                     ` Andreas Hartmann
2012-01-23 13:29                       ` Helmut Schaa
2012-01-23 16:03                         ` Andreas Hartmann
2012-01-23 16:36                           ` Helmut Schaa
2012-01-23 17:44                             ` Andreas Hartmann
2012-01-24  8:07                               ` Helmut Schaa
2012-01-24 14:39                                 ` Stanislaw Gruszka
2012-01-24 15:19                                   ` Helmut Schaa
2012-01-24  7:29                         ` Stanislaw Gruszka [this message]
2012-01-24  8:01                           ` Andreas Hartmann
2012-01-24  8:06                           ` Helmut Schaa
2012-01-04 12:29     ` Andreas Hartmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120124072946.GB2420@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=andihartmann@01019freenet.de \
    --cc=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).