From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: Daniel Halperin <dhalperi@cs.washington.edu>,
Felix Fietkau <nbd@openwrt.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht should not override user supplied rts setting
Date: Sat, 28 Jan 2012 23:14:52 +0100 [thread overview]
Message-ID: <20120128221452.GB22180@pandem0nium> (raw)
In-Reply-To: <201201290435.14048.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]
I agree to Marek here - if I want to disable RTS (for whatever reason), I type
iw phy0 set rts off
I would expect to see no RTS frames coming from my WiFi card at all. If the
rate control algorithm (whether ath9k or minstrel_ht) wants to be clever, it should
still respect this decision. The oven in my kitchen also has a temperature regulator,
but if I turn it off I also don't want my oven to be too clever and burn down the house. ;)
I know, apples and oranges, but I hope this makes this point understandable. I also
had quite a debugging night to find the reason for these "wild rts" frames.
Can't we add something two states, like:
* "RTS really off" and
* "RTS usually off, but rc's may still use it" ?
Cheers,
Simon
On Sun, Jan 29, 2012 at 04:35:13AM +0800, Marek Lindner wrote:
> On Sunday, January 29, 2012 04:26:29 Daniel Halperin wrote:
> > >> Can you explain what the low-level behavior of an RTS/CTS "battle" is?
> > >>
> > >> Abstractly, the behavior you're describing sounds like a buggy driver
> > >> that doesn't obey overheard RTS or CTS packets.
> > >
> > > I certainly can explain it but this is for another thread and unrelated
> > > to the points raised before.
> >
> > Frankly, the correctness of your argument depend on whether there's a
> > bug or not. If the difference is -2% normally and +300% in bad
> > interference conditions, you're going to lose this debate. If the
> > difference is legitimately -99% normally, you might win.
>
> I don't quite follow you here. Are you saying it should only be possible to
> disable rts/cts if I currently have a bug in my rts/cts implementation ?
>
> Keep in mind that I am not asking to disable/ban rts/cts for everyone. I'd
> like minstrel_ht to not override my rts/cts setting if I wish to disable it.
>
> Regards,
> Marek
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-28 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 7:17 [RFC] minstrel_ht should not override user supplied rts Marek Lindner
2012-01-28 7:17 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Marek Lindner
2012-01-28 13:25 ` Felix Fietkau
2012-01-28 18:43 ` Marek Lindner
2012-01-28 18:51 ` Felix Fietkau
2012-01-28 19:17 ` Daniel Halperin
2012-01-28 19:28 ` Felix Fietkau
2012-01-28 19:58 ` Marek Lindner
2012-01-28 20:03 ` Daniel Halperin
2012-01-28 20:09 ` Marek Lindner
2012-01-28 20:26 ` Daniel Halperin
2012-01-28 20:35 ` Marek Lindner
2012-01-28 22:14 ` Simon Wunderlich [this message]
2012-01-29 2:36 ` Felix Fietkau
2012-01-28 20:20 ` Felix Fietkau
2012-01-28 20:23 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 9:52 iwlwifi updates for 3.6 Johannes Berg
2012-06-11 9:53 ` [PATCH 09/13] iwlwifi: comment that setting driver_data overrides info->control Johannes Berg
2014-09-23 10:10 ` [PATCH] mac80211: minstrel_ht should not override user supplied rts setting Guido Gavilanes
2014-09-23 11:44 Guido Gavilanes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128221452.GB22180@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=dhalperi@cs.washington.edu \
--cc=lindner_marek@yahoo.de \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox