From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, users@rt2x00.serialmonkey.com
Subject: Re: [rt2x00-users] [PATCH 2/4] rt2800: radio 3xxx: program RF_R1 during channel switch
Date: Wed, 1 Feb 2012 16:21:57 +0100 [thread overview]
Message-ID: <20120201152156.GE10045@redhat.com> (raw)
In-Reply-To: <CAL1gcdOC8ygHfvqoQewShuXJm25pOaL7CWkoX3wcSZcyJkwaUw@mail.gmail.com>
On Tue, Jan 31, 2012 at 06:00:09PM +0100, Gertjan van Wingerde wrote:
> > Not only the code is different, but RF_R1 register value we program
> > is different for 30xx and 33xx when chain_num == 1 (changed by
> > RFCSR1_{RX2,TX2)_PD bit).
> >
> > I'm not against merging these two cases and program different values
> > into register than Ralink driver do, but maybe in the next linux
> > release (counting from release of that change), so any breakage
> > eventually caused by that merge could be easily detected.
>
> OK. Indeed let's do this in a different commit, at least. I don't know
> if it has to be a
> different kernel release, as long as we are able to bisect it.
Average users are using only released stuff, so if this patch fix
any practical problem i.e. throughput, and merging code will break
that again, fix and new breakage will stay unnoticed.
> Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
>
> for this patch as well.
Thanks
Stanislaw
next prev parent reply other threads:[~2012-02-01 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 15:17 [PATCH 1/4] rt2800: radio 3xxx: reprogram only lower bits of RF_R3 Stanislaw Gruszka
2012-01-30 15:17 ` [PATCH 2/4] rt2800: radio 3xxx: program RF_R1 during channel switch Stanislaw Gruszka
2012-01-30 22:06 ` [rt2x00-users] " Gertjan van Wingerde
2012-01-31 8:14 ` Stanislaw Gruszka
2012-01-31 17:00 ` Gertjan van Wingerde
2012-02-01 15:21 ` Stanislaw Gruszka [this message]
2012-01-30 15:17 ` [PATCH 3/4] rt2800: radio 3xxx: add channel switch calibration routines Stanislaw Gruszka
2012-02-01 10:30 ` Helmut Schaa
2012-01-30 15:17 ` [PATCH 4/4] rt2800: radio 3xxxx: channel switch RX/TX calibration fixes Stanislaw Gruszka
2012-01-30 22:12 ` [rt2x00-users] " Gertjan van Wingerde
2012-02-01 15:17 ` [PATCH 5/4] rt2800: document RF_R03 register bits [7:4] Stanislaw Gruszka
2012-02-01 17:00 ` Helmut Schaa
2012-02-01 19:11 ` [rt2x00-users] " Gertjan van Wingerde
2012-02-01 10:27 ` [PATCH 1/4] rt2800: radio 3xxx: reprogram only lower bits of RF_R3 Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120201152156.GE10045@redhat.com \
--to=sgruszka@redhat.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).