From: "John W. Linville" <linville@tuxdriver.com>
To: Rick Farina <sidhayn@gmail.com>
Cc: mcgrof@gmail.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS
Date: Mon, 6 Feb 2012 11:16:52 -0500 [thread overview]
Message-ID: <20120206161652.GB21048@tuxdriver.com> (raw)
In-Reply-To: <1328542936-20963-1-git-send-email-sidhayn@gmail.com>
On Mon, Feb 06, 2012 at 10:42:16AM -0500, Rick Farina wrote:
> When editing config.mk with a sed script the missing =y on this line
> causes issue. Since this line is commented out by default this means no
> changes to the default behavior and sed scripts will be able to edit the
> config.mk file much more easily.
>
> Signed-of-By: Rick Farina <sidhayn@gmail.com>
> ---
> config.mk | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/config.mk b/config.mk
> index 9433ce9..a9d189e 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -639,7 +639,7 @@ CONFIG_RT2X00_LIB_LEDS=y
> endif #CONFIG_LEDS_CLASS
> endif #CONFIG_COMPAT_KERNEL_2_6_25
> # CONFIG_RT2X00_DEBUG=y
> -# CONFIG_RT2X00_LIB_DEBUGFS
> +# CONFIG_RT2X00_LIB_DEBUGFS=y
> endif
>
> # p54
Isn't it more common to say "is not set" for Kconfig stuff that is commented out?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-02-06 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 15:42 [PATCH] add missing =y to CONFIG_RT2X00_LIB_DEBUGFS Rick Farina
2012-02-06 16:16 ` John W. Linville [this message]
2012-02-06 16:42 ` Richard Farina
2012-02-07 21:57 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206161652.GB21048@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=sidhayn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).