From: Stanislaw Gruszka <sgruszka@redhat.com>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 4/4] iwlwifi: use writeb,writel,readl directly
Date: Tue, 7 Feb 2012 09:22:33 +0100 [thread overview]
Message-ID: <20120207082232.GD2246@redhat.com> (raw)
In-Reply-To: <1328545972.14547.15.camel@wwguy-ubuntu>
On Mon, Feb 06, 2012 at 08:32:52AM -0800, wwguy wrote:
> I believe iwl driver were use readl/writel before switch to
> ioread32/iowrite32 (long time ago)
>
> http://www.gossamer-threads.com/lists/linux/kernel/960145
>
> also, AFAIK, the readl/writel IO functions still works but their use in
> new code is discouraged.
I do not think so, we have tons of drivers that use readl/writel.
PCI express devices can not use port-based IO, they will be
incredible slow then.
I think confusion come from a fact that iwlwifi use pci_ioremp() for
mapping registers, which can also maps port-based IO areas. Simply
changing that into pci_ioremap_bar(), and make driver depend on
CONFIG_HAS_IOMEM will remove that inconsistency.
Stanislaw
next prev parent reply other threads:[~2012-02-07 8:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 16:09 [RFC 1/4] iwlwifi: dump stack when fail to gain access to the device Stanislaw Gruszka
2012-02-06 16:08 ` wwguy
2012-02-07 8:01 ` Stanislaw Gruszka
2012-02-07 14:21 ` Guy, Wey-Yi
2012-02-08 10:52 ` Stanislaw Gruszka
2012-02-06 16:09 ` [RFC 2/4] iwlwifi: always check if got h/w access before write Stanislaw Gruszka
2012-02-06 16:13 ` wwguy
2012-02-07 8:05 ` Stanislaw Gruszka
2012-02-07 14:20 ` Guy, Wey-Yi
2012-02-06 16:09 ` [RFC 3/4] iwlwifi: cleanup/fix memory barriers Stanislaw Gruszka
2012-02-06 16:13 ` Johannes Berg
2012-02-07 8:11 ` Stanislaw Gruszka
2012-02-07 8:25 ` Johannes Berg
2012-02-06 16:09 ` [RFC 4/4] iwlwifi: use writeb,writel,readl directly Stanislaw Gruszka
2012-02-06 16:32 ` wwguy
2012-02-07 8:22 ` Stanislaw Gruszka [this message]
2012-02-07 14:22 ` Guy, Wey-Yi
2012-02-10 12:01 ` [RFC 1/4] iwlwifi: dump stack when fail to gain access to the device Stanislaw Gruszka
2012-02-23 10:14 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120207082232.GD2246@redhat.com \
--to=sgruszka@redhat.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).