From: Stanislaw Gruszka <sgruszka@redhat.com>
To: John Li <john.li.mediatek@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
John Li <chen-yang.li@mediatek.com>
Subject: Re: [rt2x00-users] [PATCH] rt2x00:Add RT5372 chipset support
Date: Wed, 8 Feb 2012 16:26:44 +0100 [thread overview]
Message-ID: <20120208152643.GA24072@redhat.com> (raw)
In-Reply-To: <1328706002-11165-1-git-send-email-john.li.mediatek@gmail.com>
Since already Helmut complains about coding style, I'll add my
2 cents too:
On Wed, Feb 08, 2012 at 09:00:02PM +0800, John Li wrote:
> - if (!rt2x00_rt(rt2x00dev, RT5390)) {
> + if (!rt2x00_rt(rt2x00dev, RT5390) ||
> + !rt2x00_rt(rt2x00dev, RT5392)) {
Please make alignments like in example below (few spaces
instead of last tab).
if (!rt2x00_rt(rt2x00dev, RT5390) ||
!rt2x00_rt(rt2x00dev, RT5392)) {
Thanks
Stanislaw
next prev parent reply other threads:[~2012-02-08 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 13:00 [PATCH] rt2x00:Add RT5372 chipset support John Li
2012-02-08 13:44 ` Helmut Schaa
2012-02-08 15:26 ` Stanislaw Gruszka [this message]
2012-02-08 22:34 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208152643.GA24072@redhat.com \
--to=sgruszka@redhat.com \
--cc=chen-yang.li@mediatek.com \
--cc=john.li.mediatek@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).