From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Harry Wei <harryxiyou@gmail.com>,
Jouni Malinen <jouni.malinen@atheros.com>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] Staging: wlan-ng: memsetting the wrong amount of data
Date: Wed, 22 Feb 2012 10:54:38 +0300 [thread overview]
Message-ID: <20120222075438.GA3680@mwanda> (raw)
In-Reply-To: <4F43C8CE.8060602@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Tue, Feb 21, 2012 at 05:39:42PM +0100, walter harms wrote:
> > - memset(&(msg1.bssid.data), 0xFF, sizeof(p80211item_pstr6_t));
> > + memset(&msg1.bssid.data, 0xFF, sizeof(msg1.bssid.data));
> > msg1.bssid.data.len = 6;
>
> maybe msg1.bssid.data.len is related to msg1.bssid.data ?
> I guess sizeof(msg1.bssid.data)-1 (why -1).
>
> perhaps you can fix both ?
>
It's an interesting point. The problem is that I don't actually
have this hardware. On the patch which I sent, it was obvious what
the intent. My guess is that msg1.bssid.data[] should have 6
elements instead of 7, but I don't feel confident enough to sign off
on that.
Let's fix this bug which is obvious and let someone who knows how to
fix that other question address it.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next parent reply other threads:[~2012-02-22 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120221141838.GA7998@elgon.mountain>
[not found] ` <4F43C8CE.8060602@bfs.de>
2012-02-22 7:54 ` Dan Carpenter [this message]
2012-02-22 8:08 ` [patch] Staging: wlan-ng: memsetting the wrong amount of data walter harms
2012-02-23 22:55 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222075438.GA3680@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harryxiyou@gmail.com \
--cc=jouni.malinen@atheros.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).