From: Christian Lamparter <chunkeey@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <j@w1.fi>,
Nicolas Cavallari <Nicolas.Cavallari@lri.fr>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] carl9170: Fix memory accounting when sta is in power-save mode.
Date: Sat, 25 Feb 2012 21:20:01 +0100 [thread overview]
Message-ID: <201202252120.01430.chunkeey@googlemail.com> (raw)
In-Reply-To: <1330200772.3509.0.camel@jlt3.sipsolutions.net>
On Saturday 25 February 2012 21:12:52 Johannes Berg wrote:
> On Sat, 2012-02-25 at 11:32 +0200, Jouni Malinen wrote:
> > On Fri, Feb 24, 2012 at 03:09:02PM +0100, Johannes Berg wrote:
> > > On Fri, 2012-02-24 at 15:01 +0100, Nicolas Cavallari wrote:
> > > > Hostapd already does that¹ ... after the association response is acked.
> > >
> > > Ok maybe then we should send out assoc resp etc. frames and not subject
> > > them to PS queueing? Jouni?
> >
> > We should try to follow the clarified description of management frame
> > buffering in P802.11-REVmb/D12.0 (i.e., soon to be published IEEE Std
> > 802.11-2012). (Re)Association Response frame is not a bufferable
> > management frame and as such, it needs to be sent out without being
> > subject to PS queuing.
>
> Ah yes, you mentioned before that this was being clarified but I forgot
> about it again. I'll take a look.
>
Actually, I think I found the problem in carl9170 [writing a patch atm].
[I forgot to check IEEE80211_TX_CTL_POLL_RESPONSE and
IEEE80211_TX_CTL_CLEAR_PS_FILT flags].
[A simple fix: we could set something like TX_CTL_IGNORE_PS
(now known as TX_CTL_POLL_RESPONSE) on outgoing
auth & (re-)assoc frames]
Regards,
Chr
next prev parent reply other threads:[~2012-02-25 20:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 15:53 [RFC] carl9170: Fix memory accounting when sta is in power-save mode Nicolas Cavallari
2012-02-23 16:52 ` Christian Lamparter
2012-02-23 17:27 ` Nicolas Cavallari
2012-02-23 18:08 ` Christian Lamparter
2012-02-23 18:51 ` Nicolas Cavallari
2012-02-24 13:34 ` Nicolas Cavallari
2012-02-24 13:39 ` Johannes Berg
2012-02-24 14:01 ` Nicolas Cavallari
2012-02-24 14:09 ` Johannes Berg
2012-02-25 9:32 ` Jouni Malinen
2012-02-25 20:12 ` Johannes Berg
2012-02-25 20:20 ` Christian Lamparter [this message]
2012-02-24 14:07 ` Christian Lamparter
2012-02-24 20:43 ` Christian Lamparter
2012-02-25 20:36 ` [PATCH -stable] carl9170: fix frame delivery if sta is in powersave mode Christian Lamparter
2012-02-27 12:00 ` Nicolas Cavallari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202252120.01430.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Nicolas.Cavallari@lri.fr \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).