From: "John W. Linville" <linville@tuxdriver.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Yogesh Powar <yogeshp@marvell.com>,
Avinash Patil <patila@marvell.com>,
Frank Huang <frankh@marvell.com>
Subject: Re: [PATCH 3.3] mwifiex: reset encryption mode flag before association
Date: Mon, 27 Feb 2012 13:23:13 -0500 [thread overview]
Message-ID: <20120227182312.GB26664@tuxdriver.com> (raw)
In-Reply-To: <1330148136-28867-1-git-send-email-bzhao@marvell.com>
On Fri, Feb 24, 2012 at 09:35:35PM -0800, Bing Zhao wrote:
> From: Amitkumar Karwar <akarwar@marvell.com>
>
> Recent commit
> "mwifiex: clear previous security setting during association"
> fixes association failure problems observed in some corner cases
> by clearing previous security setting before each association.
>
> We should reset encryption mode flag as well. This patch takes care
> of it.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
> ---
> drivers/net/wireless/mwifiex/cfg80211.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c
> index 8d8ee63..e4e6d7d 100644
> --- a/drivers/net/wireless/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/mwifiex/cfg80211.c
> @@ -872,6 +872,7 @@ mwifiex_cfg80211_assoc(struct mwifiex_private *priv, size_t ssid_len, u8 *ssid,
> priv->sec_info.wpa_enabled = false;
> priv->sec_info.wpa2_enabled = false;
> priv->wep_key_curr_index = 0;
> + priv->sec_info.encryption_mode = 0;
> ret = mwifiex_set_encode(priv, NULL, 0, 0, 1);
>
> if (mode == NL80211_IFTYPE_ADHOC) {
What bug does this fix? Does it need to be fixed in 3.3? Or can it wait for 3.4?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2012-02-27 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 5:35 [PATCH 3.3] mwifiex: reset encryption mode flag before association Bing Zhao
2012-02-25 5:35 ` [PATCH 3.3] mwifiex: remove redundant scan operation Bing Zhao
2012-02-27 18:23 ` John W. Linville
2012-02-27 23:47 ` Bing Zhao
2012-02-27 18:23 ` John W. Linville [this message]
2012-02-27 23:44 ` [PATCH 3.3] mwifiex: reset encryption mode flag before association Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227182312.GB26664@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=frankh@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=patila@marvell.com \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).