From: Kalle Valo <kvalo@qca.qualcomm.com>
To: kvalo@qca.qualcomm.com
Cc: ath6kl-devel@qualcomm.com, linux-wireless@vger.kernel.org
Subject: [PATCH 00/12] ath6kl: checkpatch fixes
Date: Wed, 29 Feb 2012 19:18:18 +0200 [thread overview]
Message-ID: <20120229171525.24264.22062.stgit@localhost6.localdomain6> (raw)
Here are quite a few checkpatch fixes and other cleanups.
Especially I would like to people review these two macros, they ended up
a bit too clever and I'm sure there are issues:
#define ath6kl_bmi_write_hi32(ar, item, val) \
({ \
u32 addr; \
__le32 v; \
\
addr = ath6kl_get_hi_item_addr(ar, HI_ITEM(item)); \
v = cpu_to_le32(val); \
ath6kl_bmi_write(ar, addr, (u8 *) &v, sizeof(v)); \
})
#define ath6kl_bmi_read_hi32(ar, item, val) \
({ \
u32 addr, *check_type = val; \
__le32 tmp; \
int ret; \
\
(void) (check_type == val); \
addr = ath6kl_get_hi_item_addr(ar, HI_ITEM(item)); \
ret = ath6kl_bmi_read(ar, addr, (u8 *) &tmp, 4); \
*val = le32_to_cpu(tmp); \
ret; \
})
---
Kalle Valo (12):
ath6kl: fix pointer style
ath6kl: fix checkpatch error with EPSTAT() macro
ath6kl: alignment should match open parenthesis
ath6kl: logical continuations should be on the previous line
ath6kl: remove multiple assignments
ath6kl: add ath6kl_bmi_write_hi32()
ath6kl: add ath6kl_bmi_read_hi32()
ath6kl: fix error handling ath6kl_target_config_wlan_params()
ath6kl: fix open paranthesis alignment in ath6kl_cfg80211_connect()
ath6kl: document all spinlocks
ath6kl: fix too long lines
ath6kl: make ath6kl_bmi_[read|write]_hi32() endian safe
drivers/net/wireless/ath/ath6kl/bmi.c | 6 -
drivers/net/wireless/ath/ath6kl/bmi.h | 23 +++
drivers/net/wireless/ath/ath6kl/cfg80211.c | 46 ++++--
drivers/net/wireless/ath/ath6kl/core.c | 6 -
drivers/net/wireless/ath/ath6kl/core.h | 25 +++
drivers/net/wireless/ath/ath6kl/debug.c | 58 ++++----
drivers/net/wireless/ath/ath6kl/hif.c | 6 -
drivers/net/wireless/ath/ath6kl/hif.h | 1
drivers/net/wireless/ath/ath6kl/htc.c | 105 +++++++-------
drivers/net/wireless/ath/ath6kl/htc.h | 7 +
drivers/net/wireless/ath/ath6kl/init.c | 203 ++++++++++------------------
drivers/net/wireless/ath/ath6kl/main.c | 22 ++-
drivers/net/wireless/ath/ath6kl/sdio.c | 11 +-
drivers/net/wireless/ath/ath6kl/txrx.c | 18 +-
drivers/net/wireless/ath/ath6kl/wmi.c | 31 ++--
drivers/net/wireless/ath/ath6kl/wmi.h | 6 +
16 files changed, 295 insertions(+), 279 deletions(-)
next reply other threads:[~2012-02-29 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:18 Kalle Valo [this message]
2012-02-29 17:18 ` [PATCH 01/12] ath6kl: fix pointer style Kalle Valo
2012-02-29 17:18 ` [PATCH 02/12] ath6kl: fix checkpatch error with EPSTAT() macro Kalle Valo
2012-02-29 17:18 ` [PATCH 03/12] ath6kl: alignment should match open parenthesis Kalle Valo
2012-03-07 19:26 ` Joe Perches
2012-03-07 20:18 ` Kalle Valo
2012-02-29 17:19 ` [PATCH 04/12] ath6kl: logical continuations should be on the previous line Kalle Valo
2012-02-29 17:19 ` [PATCH 05/12] ath6kl: remove multiple assignments Kalle Valo
2012-02-29 17:19 ` [PATCH 06/12] ath6kl: add ath6kl_bmi_write_hi32() Kalle Valo
2012-02-29 17:19 ` [PATCH 07/12] ath6kl: add ath6kl_bmi_read_hi32() Kalle Valo
2012-02-29 17:19 ` [PATCH 08/12] ath6kl: fix error handling ath6kl_target_config_wlan_params() Kalle Valo
2012-02-29 17:19 ` [PATCH 09/12] ath6kl: fix open paranthesis alignment in ath6kl_cfg80211_connect() Kalle Valo
2012-02-29 17:19 ` [PATCH 10/12] ath6kl: document all spinlocks Kalle Valo
2012-02-29 17:20 ` [PATCH 11/12] ath6kl: fix too long lines Kalle Valo
2012-02-29 17:20 ` [PATCH 12/12] ath6kl: make ath6kl_bmi_[read|write]_hi32() endian safe Kalle Valo
2012-02-29 17:37 ` [PATCH 00/12] ath6kl: checkpatch fixes Joe Perches
2012-02-29 17:41 ` Kalle Valo
2012-02-29 18:21 ` Joe Perches
2012-03-05 16:33 ` Kalle Valo
2012-03-07 17:57 ` Kalle Valo
2012-03-07 18:37 ` Joe Perches
2012-03-07 19:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229171525.24264.22062.stgit@localhost6.localdomain6 \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox