From: Christian Lamparter <chunkeey@googlemail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 4/5] p54pci: Load firmware from work queue and not from probe routine
Date: Wed, 29 Feb 2012 19:27:02 +0100 [thread overview]
Message-ID: <201202291927.02473.chunkeey@googlemail.com> (raw)
In-Reply-To: <4F4E6B43.6050204@lwfinger.net>
On Wednesday, February 29, 2012 07:15:31 PM Larry Finger wrote:
> On 02/29/2012 11:43 AM, Christian Lamparter wrote:
> > On Wednesday, February 29, 2012 04:59:14 PM Larry Finger wrote:
> >> On 02/13/2012 01:37 PM, Larry Finger wrote:
> >> Has anyone tested this patch? I would like to submit this series.
> > only briefly, but I'm not sure if the workqueue approach is adequate. On
> > resume, I get WARNINGs and the card fails to resume because the firmware
> > file can't be loaded :(.
> >
> > WARNING: at drivers/base/firmware_class.c:538 _request_firmware+0x3ae/0x3e0()
> > Pid: 1083, comm: kworker/0:3 Tainted:G O 3.3.0-rc5-wl+
> > Call Trace:
> > [<c102c658>] ? wanr_slowpath_common+0x78/0xb0
> > [<c12c728e>] ? _request_firmware+0x3ae/0x3e0
> > [<c12c728e>] ? _requrst_firmware+0x3ae/0x3e0
> > [<c102c6a9>] ? warn_slowpath_common+0x19/0x20
> > [<c12c728e>] ? _request_firmware+0x3ae/0x3e0
> > [<c12c7347>] ? request_firmware+0x17/0x20
> > [<f86v1dc7>] ? p54p_load_firmware+0x47/0x120 [p54pci]
> > [...]
> >
> > Regards,
> > Chr
> >
> > BTW: I will take a closer look at it over the weekend.
>
> Does the driver come back through the probe routine on resume?
Yes. I've got a pcmcia card [in fact I have two :D]. The pcmcia
subsystem goes to a rebind on resume.
Regards,
Christian
next prev parent reply other threads:[~2012-02-29 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 19:37 [RFC/RFT 0/5] Firmware load change for various wireless drivers Larry Finger
2012-02-13 19:37 ` [RFC/RFT 1/5] b43legacy: Load firmware from work queue instead of from probe routine Larry Finger
2012-02-13 19:37 ` [RFC/RFT 2/5] b43: Load firmware from a work queue and not from the " Larry Finger
2012-02-13 23:06 ` Julian Calaby
2012-02-13 23:28 ` Larry Finger
2012-02-13 23:41 ` Julian Calaby
2012-02-13 23:51 ` Larry Finger
2012-02-13 19:37 ` [RFC/RFT 3/5] p54usb: Load firmware from work queue and not from " Larry Finger
2012-02-13 19:37 ` [PATCH 4/5] p54pci: " Larry Finger
2012-02-29 15:59 ` Larry Finger
2012-02-29 17:43 ` Christian Lamparter
2012-02-29 18:15 ` Larry Finger
2012-02-29 18:27 ` Christian Lamparter [this message]
2012-02-13 19:37 ` [RFC/RFT 5/5] p54spi: " Larry Finger
2012-02-13 21:57 ` Michael Büsch
2012-02-29 16:00 ` Larry Finger
2012-02-29 19:54 ` Max Filippov
2012-02-29 20:01 ` Larry Finger
2012-02-14 10:56 ` [RFC/RFT 0/5] Firmware load change for various wireless drivers Johannes Berg
2012-02-14 16:34 ` Larry Finger
2012-02-14 16:37 ` Johannes Berg
2012-02-14 16:57 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202291927.02473.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).