From: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: Add an attribute to set inactivity timeout in AP mode
Date: Fri, 2 Mar 2012 15:48:30 +0530 [thread overview]
Message-ID: <20120302101829.GA7154@vasanth-laptop> (raw)
In-Reply-To: <1330678884.8542.11.camel@jlt3.sipsolutions.net>
On Fri, Mar 02, 2012 at 10:01:24AM +0100, Johannes Berg wrote:
> Hi Vasanth,
>
> On Thu, 2012-03-01 at 20:51 +0530, Vasanthakumar Thiagarajan wrote:
> > + * @NL80211_ATTR_INACTIVITY_TIMER_SUPPORT: Indicates if the driver has the
> > + * capability to use %NL80211_ATTR_INACTIVITY_TIMEOUT for freeing up
> > + * connected stations.
>
> I think now that we have "enum nl80211_feature_flags" you could just add
> a flag to it.
Good point, thanks.
>
> > + * @NL80211_ATTR_INACTIVITY_TIMEOUT: timeout value in seconds, this can be
> > + * used by the drivers which has MLME in firmware and does not have support
> > + * to report per station tx/rx activity to free up the staion entry from
> > + * the list. This should not be sent from userspace when the driver does
> > + * not register it's capability to timeout the stations.
>
> Shouldn't that be the other way around -- it needs to be used when the
> driver *does* advertise support for it?
>
Ah, right, thanks.
>
> > + WIPHY_FLAG_SUPPORTS_INACTIVITY_TIMER = BIT(22),
>
> If you use nl80211_feature_flags you also don't need this wiphy to
> feature translation, the driver can directly set those flags.
Right.
Vasanth
next prev parent reply other threads:[~2012-03-02 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 15:21 [PATCH] cfg80211: Add an attribute to set inactivity timeout in AP mode Vasanthakumar Thiagarajan
2012-03-02 9:01 ` Johannes Berg
2012-03-02 10:18 ` Vasanthakumar Thiagarajan [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-01 12:52 Vasanthakumar Thiagarajan
2012-03-01 14:21 ` Johannes Berg
2012-03-01 14:27 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302101829.GA7154@vasanth-laptop \
--to=vthiagar@qca.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).