* re: {nl,cfg,mac}80211: Implement RSSI threshold for mesh peering
@ 2012-03-06 10:57 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-03-06 10:57 UTC (permalink / raw)
To: ashok; +Cc: linux-wireless
Hello Ashok Nagarajan,
This is a semi-automatic email about new static checker warnings.
The patch 5533513784a8: "{nl,cfg,mac}80211: Implement RSSI threshold
for mesh peering" from Feb 28, 2012, leads to the following Smatch
complaint:
net/mac80211/mesh_plink.c:542 mesh_rx_plink_frame()
error: we previously assumed 'sta' could be null (see line 534)
net/mac80211/mesh_plink.c
533 sta = sta_info_get(sdata, mgmt->sa);
534 if (!sta && ftype != WLAN_SP_MESH_PEERING_OPEN) {
^^^^
old check.
535 mpl_dbg("Mesh plink: cls or cnf from unknown peer\n");
536 rcu_read_unlock();
537 return;
538 }
539
540 if (ftype == WLAN_SP_MESH_PEERING_OPEN &&
541 !sta_meets_rssi_threshold(sta, sdata)) {
^^^^^^^^^^^^^^^^^^^^^^^^
new dereference.
542 mpl_dbg("Mesh plink: %pM does not meet rssi threshold\n",
543 sta->sta.addr);
^^^^^
new dereference.
544 rcu_read_unlock();
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-03-06 10:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-06 10:57 {nl,cfg,mac}80211: Implement RSSI threshold for mesh peering Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).