From: Christian Lamparter <chunkeey@googlemail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/5 V2] p54usb: Load firmware from work queue and not from probe routine
Date: Fri, 9 Mar 2012 22:45:14 +0100 [thread overview]
Message-ID: <201203092245.14420.chunkeey@googlemail.com> (raw)
In-Reply-To: <1331267337-19605-1-git-send-email-Larry.Finger@lwfinger.net>
On Friday, March 09, 2012 05:28:57 AM Larry Finger wrote:
> Drivers that load firmware from their probe routine have problems with the
> latest versions of udev as they get timeouts while waiting for user
> space to start. The problem is fixed by loading the firmware and starting
> mac80211 from a work queue. By using this method, most of the
> original code is preserved.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
Well, I thought this over and I think unless we change the Kconfig
and make the backend modules [p54pci, p54usb and p54spi]
module-only options, we have to go with request_firmware_nowait.
You see, if the p54* modules are compiled into the very bzImage:
The instant workqueue option wouldn't work because the device
might be initialized before the filesystem is. A combo approach
[delayed workqueue, when no userspacehelper is available and a
direct call to request_firmware (when it is availabe)] would
work too, but then we would be reimplementing
request_firmware_nowait ...
Regards,
Chr
next prev parent reply other threads:[~2012-03-09 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 4:28 [PATCH 3/5 V2] p54usb: Load firmware from work queue and not from probe routine Larry Finger
2012-03-09 21:45 ` Christian Lamparter [this message]
2012-03-09 23:45 ` Larry Finger
2012-03-10 0:21 ` Christian Lamparter
2012-03-16 21:51 ` Christian Lamparter
2012-03-17 2:17 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203092245.14420.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).