* [PATCH] rt2x00: Set IEEE80211_HW_REPORTS_TX_ACK_STATUS in rt2800
@ 2012-03-14 7:56 Helmut Schaa
2012-03-14 10:31 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Helmut Schaa @ 2012-03-14 7:56 UTC (permalink / raw)
To: linux-wireless; +Cc: linville, IvDoorn, gwingerde, sgruszka, Helmut Schaa
rt2800 already reports the tx ack status of each frame back to mac80211.
Advertise this by setting IEEE80211_HW_REPORTS_TX_ACK_STATUS for rt2800.
This allows some mac80211 features like frame loss notifications to work
with rt2800.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
I don't see a problem with enabling this for rt2800pci.
Ivo, Gertjan, Stanislaw, any objection against enabling for rt2800usb?
Thanks,
Helmut
drivers/net/wireless/rt2x00/rt2800lib.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 79a9eeb..4d7dc7b 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -4504,7 +4504,9 @@ int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
IEEE80211_HW_SIGNAL_DBM |
IEEE80211_HW_SUPPORTS_PS |
IEEE80211_HW_PS_NULLFUNC_STACK |
- IEEE80211_HW_AMPDU_AGGREGATION;
+ IEEE80211_HW_AMPDU_AGGREGATION |
+ IEEE80211_HW_REPORTS_TX_ACK_STATUS;
+
/*
* Don't set IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING for USB devices
* unless we are capable of sending the buffered frames out after the
--
1.7.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rt2x00: Set IEEE80211_HW_REPORTS_TX_ACK_STATUS in rt2800
2012-03-14 7:56 [PATCH] rt2x00: Set IEEE80211_HW_REPORTS_TX_ACK_STATUS in rt2800 Helmut Schaa
@ 2012-03-14 10:31 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2012-03-14 10:31 UTC (permalink / raw)
To: Helmut Schaa; +Cc: linux-wireless, linville, IvDoorn, gwingerde
On Wed, Mar 14, 2012 at 08:56:47AM +0100, Helmut Schaa wrote:
> rt2800 already reports the tx ack status of each frame back to mac80211.
> Advertise this by setting IEEE80211_HW_REPORTS_TX_ACK_STATUS for rt2800.
> This allows some mac80211 features like frame loss notifications to work
> with rt2800.
>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
> ---
>
> I don't see a problem with enabling this for rt2800pci.
> Ivo, Gertjan, Stanislaw, any objection against enabling for rt2800usb?
I did short testings and did not found any problems.
Stanislaw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-14 10:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 7:56 [PATCH] rt2x00: Set IEEE80211_HW_REPORTS_TX_ACK_STATUS in rt2800 Helmut Schaa
2012-03-14 10:31 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).